-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/account-wizard] Add account wizard #1274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace for the logo image
Co-authored-by: Michael Stingl <[email protected]>
* Remove old PLIST examples * move ownCloud.online theme + assets * move EMM assets * Adjust Fastfile for moved themes + assets * updated to Xcode 14.3 * move all app resources to the correct place in one copy command * updated to 14.3.1 --------- Co-authored-by: Michael Stingl <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>
- added accessibility label to the logo image
- add support for RGBA hex values to CSS
…screen background (#1264) * - add background image to welcome screen - add support for RGBA hex values to CSS * Assets.xcassets/AppIcon.appiconset generated with fastlane * align icon name with branding --------- Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: Michael Stingl <[email protected]>
…cords for colors, incl. a set of system colors - ThemeCollection: add system colors (f.ex. UIColor.systemBlue as `os.color.blue`) and theme base colors (as `theme.color.light` and `theme.color.dark`) to CSS object
- add permanent logo branding to top of the view - make branding elements use same CSS selectors as welcome screen - ComposedMessageView: make CSS selectors extension public - RoundCornerBackgroundView: add new .fillImage property that allows filling the view with an image with "scaleAspectFill" contentMode
…uld fix crash reported in #1245 (comment))
…into milestone/12.0.3
…lor and label was not readable, if lightBrandColor was similar to #000000
…ErrorForNonExistentItemWithIdentifier:]` for the case that iOS (illegally) passes in a nil `identifier`, leading to a crash in said NSError method
This is approved on my side! Xcode version: Approved commits: app: Devices: iPhoneXR iOS 17.2 Tests reports: Test plan: https://github.com/owncloud/QA/blob/master/Mobile/iOS/Executions/Version%2012.1/Regression.md vs oCIS 4 (current oCIS stable) vs oCIS 5 (new incoming oCIS version, currently in beta) |
… option to allow omitting parameters from authorization requests (implements #1318)
9 tasks
…ht and system dark. Allow theme selection for all clients.
- removed allowed authentication methods - added more allowed hosts
- updated build number
* [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex --------- Co-authored-by: ownClouders <[email protected]>
jesmrec
approved these changes
Jan 29, 2024
- changed changelog release date
…ios-app into feature/account-wizard
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #1322
Description
authentication-oauth2.omit-authorization-parameters
to allow omitting parameters from authorization requests ([FEATURE REQUEST] [OIDC] Branding option to remove "login_hint" and "user" parameter from re-login URL #1318)Screenshots (if appropriate):
Branding changes
Branding assets
Branding assets are now picked and copied dynamically based on their existence and contents:
ownCloud/Resources/Theming/com.owncloud.ios-app
is used by defaultownCloud/Resources/Theming/branding-assets
is used instead if there's at least one file in it matching thebranding-*.png
patternProblems solved:
Supported assets:
branding-splashscreen-logo.png
branding-splashscreen-background.png
branding-logo.png
BrandView
in the setup wizard and sidebar branding pill.branding-background.png
BrandView
in the setup wizard and sidebar branding pill.branding-logo-setup.png
branding-logo.png
to be used in account setup.branding-background-setup.png
branding-background.png
to be used in account setup.branding-logo-sidebar.png
branding-logo.png
to be used in the sidebar branding pill.branding-background-sidebar.png
branding-background.png
to be used in the sidebar branding pill.branding-login-logo.png
branding-logo.png
, supported as a fallback only.branding-login-background.png
branding-background.png
, supported as a fallback only.branding-logo.png
fastlane/Fastfile
)branding-sidebar-link-icon.png
alongside sidebar links.For it to be used
at all, it must be referenced
in the respective
branding.sidebar-links
entry/entries. There is no code referencing it.
Default Theme and customizable light/dark themes based on system colors
The default theme is no longer the first theme in the list (typically
Light
), butFollow System Appearance
, so the app follows light and dark mode as used by the system.If
branding.theme-definitions
is not used, the app now provides themes for light mode and dark mode to branded clients, with support for light customization through branding:branding.theme-colors
branding.theme-css-records
Both options can be used together.
Supported
branding.theme-colors
keys/aliasestint-color
branding.theme-tint-color
.branding-background-color
setup-status-bar-style
default
,black
orwhite
.file-icon-color
folder-icon-color
Each alias can be expanded to one or more CSS addresses internally, so that the values set here can be assigned to the right elements - even after major UI changes or refactoring.
Example:
Removal of unused branding options
branding.theme-generic-colors
andbranding.theme-definitions$[X].Colors.*
were already ignored / no longer used. The remaining code referring to these options has now been removed as well.Removal of duplicate branding options
The following, duplicate branding options were removed:
account-settings.default-name
branding.profile-bookmark-name
account-settings.default-url
branding.profile-url
account-settings.url-editable
branding.profile-allow-url-configuration
Text overrides
The title and message text of each step can be overridden by targeting special translation keys through the
locale.overrides
option, following the formatsetup-[stepName]-title
andsetup-[stepName]-message
:The possible step names are
intro
,enterUsername
,serverURL
,authenticate
,chooseServer
,infinitePropfind
andcompleted
.Types of changes
Feedback
branding.can-add-account=false
ignored [feature/account-wizard] Add account wizard #1274 (comment) [FIXED]branding.can-edit-account=false
should skip Completed screen [feature/account-wizard] Add account wizard #1274 (comment) [FIXED]