Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Replace libzip with NSFileCoordinator #1218

Open
michaelstingl opened this issue Jun 13, 2023 · 1 comment
Open

[FEATURE REQUEST] Replace libzip with NSFileCoordinator #1218

michaelstingl opened this issue Jun 13, 2023 · 1 comment
Milestone

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Jun 13, 2023

@felix-schwarz could you elaborate a bit on the pro's and con's?

How is it related to the one?

@michaelstingl michaelstingl added this to the 12.1-Next milestone Jun 13, 2023
@michaelstingl michaelstingl modified the milestones: 12.1-Current, 12.2-Next Nov 3, 2023
@felix-schwarz
Copy link
Contributor

libzip was originally added to implement transparent compression of bundle formats (f.ex. Keynote documents) before uploading.

When using the NSFileCoordinator API for importing files before upload, iOS will now transparently compress bundle documents into a single file that no longer needs special handling by the ownCloud app.

That removes the original need for libzip, so that it can be removed.

If #719 shall still be pursued, however, libzip will continue to be needed. In case that decision should or can't be made now, there's also the option of keeping libzip in the project, but no longer link it into the app until it is needed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants