[QA] [email protected] can be created, when example.com is in the blocklist

[jnweiger]

Seen with guests-0.12.2-rc.1 on server 10.11.0

• occ app:enable guests
• Go to Settings -> Admin -> Sharing -> Guests section has an input field blocked domains
• enter example.com into the blocklist, click in empty space, saved appears.
• Back to files view, open sharing dialog on the Documents folder
• enter [email protected] one popups appear for federation only. OK
• enter [email protected] two popups appear, one for federation, one for sharing. BAD

Expected behaviour:

• subdomains are blocked when parent domain is blocked.

[jnweiger]

@enbrnz is this the behaviour, you wanted to implement with #529 ?

[phil-davis]

It seems sensible to me, that blocking "somedomain.co.uk" should block that whole domain, including any sub-domains. (which is the behavior that @jnweiger was expecting to see)

It needs someone to define what is the required behavior. Then we can implement test cases and adjust the code.

[enbrnz]

There are arguments for both subdomain blocking or not.
I wasn't aware that subdomain blocking is expected. I did not account for it and implemented what I meant to implement, blocking just the domains on the list.

[jnweiger]

@enbrnz I have my private opinions what I expect and not. :-)

I have no clear view, what we officially want or what customers expect.
My logic was: with the suffix match that we had before, subdomain blocking was implicit. Maybe the suffix match was initially implemented exactly to catch subdomains? -- Not sure. To be safe and backwards compatible, I am suggesting to have subdomain blocking. Simple consistency argument only.

Regarding arguments for and against: Maybe introduce a different syntax to offer both behaviors: E.g.

• @example.com blocks only example.com and
• example.com includes subdomains.