Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No unit test coverage of some classes #396

Open
6 tasks
phil-davis opened this issue Mar 4, 2020 · 0 comments
Open
6 tasks

No unit test coverage of some classes #396

phil-davis opened this issue Mar 4, 2020 · 0 comments

Comments

@phil-davis
Copy link
Contributor

When making simple changes to much of the guests app code we get codecov fails because actually there are no unit tests for classes like:

  • Controller/RegisterController
  • Controller/SettingsController
  • Controller/UsersController
  • Settings/Admin.php
  • AppWhitelist.php
  • Mail.php

Add unit tests.

Note: we have reasonable acceptance test coverage of the main functionality of guests app, so for example, PR #384 touched Controller/UsersController and codecov failed but actually the change was covered by acceptance tests anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phil-davis