Fix web update from 9.0.0 and 9.0.1 with encryption enabled

[VicDeo]

owncloud/updater#350 is fixed in updater for future releases.

This repair step fixes it for 9.0.0 and 9.0.1 too
Otherwise update will crash with

PHP Fatal error: Class OCA\\Encryption\\Crypto\\Encryption contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\\Encryption\\IEncryptionModule::isReadyForUser) in /home/deo/public_html/killme/apps/encryption/lib/crypto/encryption.php on line 550\nPHP

Unfortunately testing is tricky.

1. Install 9.0.0 or 9.0.1
2. Enable encryption
3. Switch update channel to daily
4. Relogin
5. Repack 9.1.0 beta1 to include this patch and put it on any host
6. Replace https://github.com/owncloud/updater/blob/master/src/Utils/Feed.php#L108
   return $this->url;
   with
   return 'http://url/of/repacked/beta';
7. Update

Stable9: #24854

[mention-bot]

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @PVince81 and @nickvergessen to be potential reviewers

[VicDeo]

hmm, fixing migration from 9.0.1 to 9.1 has a little sense due to owncloud/updater#336
only 9.0.3 will be upgradable to 9.1

[PVince81]

@owncloud/qa can you help testing this ?

[DeepDiver1975]

There is no point in moving this into master if this should fix some upgrade issues in 9.0.x - right?

[nickvergessen]

https://github.com/owncloud/administration-internal/issues/19

Yes, as long as we never allow updates from 9.0.0-2 to 9.1: https://github.com/owncloud/administration-internal/issues/19

[VicDeo]

@DeepDiver1975 correct, if 9.0.3 is released before 9.1.0.
In this case update sequence will be 9.0.3->9.1.0 and this PR can be closed.

[PVince81]

In this case update sequence will be 9.0.3->9.1.0

How can we enforce the update sequence 9.0.x->9.0.3 then 9.0.3->9.1.0 ?
What if someone doesn't update 9.0.x for a year, can we still enforce it ?

[VicDeo]

@PVince81

What if someone doesn't update 9.0.x for a year, can we still enforce it ?

Needs to be checked but the answer is yes at the first glance:
https://github.com/owncloud/administration-internal/blob/master/update-server/config/config.php#L151

[VicDeo]

@PVince81 according to getFuzzySearches we can even enforce 9.0.1.1 always upgrade to 9.0.1.2
because the update candidate search priority will be as follows:
9.0.1.1
9.0.1
9.0
9

[PVince81]

Great, so I guess we can close this then.

@VicDeo you should put a note somewhere to not forget about enforcing this, maybe in the updater ticket tracker ? (with sev1-critical)

[VicDeo]

@PVince81 there is an issue already https://github.com/owncloud/administration-internal/issues/19
but I think it should be put in config file directly too

[PVince81]

There is no point in moving this into master if this should fix some upgrade issues in 9.0.x - right?

I agree to discard this PR then and handle the stuff on the updater side.

@DeepDiver1975 close ?
We still need to merge the backport then.

[PVince81]

Closing then

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.