Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add Space" button text in disconnected state #11256

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Oct 2, 2023

When the account state was disconnected from an oCIS server, the button would show "Add Folder" instead of "Add Space". This also fixes the tooltip of the button.

Fixes: #11230

@erikjv erikjv requested review from TheOneRing and fmoc October 2, 2023 14:01
@erikjv erikjv self-assigned this Oct 2, 2023
@erikjv erikjv force-pushed the work/fix-add-space-button-text-when-disconnected branch from 2061e69 to e54adf4 Compare October 4, 2023 13:47
@TheOneRing TheOneRing linked an issue Oct 5, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

When the account state was disconnected from an oCIS server, the button
would show "Add Folder" instead of "Add Space". This also fixes the
tooltip of the button.

Fixes: #11230
@fmoc fmoc force-pushed the work/fix-add-space-button-text-when-disconnected branch from e8ada8e to a9b5d6d Compare October 16, 2023 10:14
@fmoc fmoc enabled auto-merge (rebase) October 16, 2023 10:14
@fmoc fmoc disabled auto-merge October 16, 2023 10:15
@fmoc fmoc enabled auto-merge (rebase) October 16, 2023 10:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fmoc fmoc merged commit a5236b9 into 5 Oct 16, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/fix-add-space-button-text-when-disconnected branch October 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Add space button gets renamed to Add folder when logged out
3 participants