Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use folder icon #11190

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Consistently use folder icon #11190

merged 1 commit into from
Sep 7, 2023

Conversation

TheOneRing
Copy link
Contributor

@TheOneRing TheOneRing commented Sep 7, 2023 •
edited
Loading

Old

thumb-Clipboard - September 7, 2023 11 38
#New
thumb-Clipboard - September 7, 2023 11 52

@TheOneRing TheOneRing requested a review from a team September 7, 2023 09:57
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit e0b3cf0 into 5 Sep 7, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/icon branch September 7, 2023 11:34
@HanaGemela
Copy link
Contributor

@TheOneRing what are the steps to test?

@TheOneRing
Copy link
Contributor Author

As you can see you won't see the system icons for folders anymore

@TheOneRing
Copy link
Contributor Author

Grr I copied the images from rocket chat and it only took the thumbnail instead of the actual full size image..

@HanaGemela
Copy link
Contributor

Test just one platform

@HanaGemela
Copy link
Contributor

Passed in ownCloud 5.0.0.12077-daily20230908, mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjv erikjv erikjv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOneRing @HanaGemela @erikjv