Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui-tests][full-ci] check the keyring and try to unlock if locked #11866

Merged
merged 4 commits into from
Sep 27, 2024
Merged

[gui-tests][full-ci] check the keyring and try to unlock if locked #11866

merged 4 commits into from
Sep 27, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Sep 10, 2024 •
edited
Loading

Check the keyring locked status and try to unlock it if locked during the test execution.

Fixes #11883

Depends on: owncloud-ci/squish#63

❌ Test fails because keyring can be locked during the test execution: https://drone.owncloud.com/owncloud/client/19470/1/10

--------------Scenario 1 (PASS)
LOG:   Start Scenario	login after logging out normal Account
LOG:   CompletedProcess(args=['busctl', '--user', 'get-property', 'org.freedesktop.secrets', '/org/freedesktop/secrets/collection/login', 'org.freedesktop.Secret.Collection', 'Locked'], returncode=0, stdout=b'b false\\n', stderr=b'')	
LOG:   b false\n
...
LOG:   End Scenario	login after logging out normal Account

--------------Scenario 2 (FAIL)
LOG:   Start Scenario	login after logging out normal Account
LOG:   CompletedProcess(args=['busctl', '--user', 'get-property', 'org.freedesktop.secrets', '/org/freedesktop/secrets/collection/login', 'org.freedesktop.Secret.Collection', 'Locked'], returncode=1, stdout=b'', stderr=b'Failed to get property Locked on interface org.freedesktop.Secret.Collection: Message recipient disconnected from message bus without replying\\n')	
LOG:   Failed to get property Locked on interface org.freedesktop.Secret.Collection: Message recipient disconnected from message bus without replying\n
...
LOG:   Start Step	Then user "Alice" should be connected to the server
ERROR: Script Error	TimeoutError: Timeout waiting for the account to be connected for 5000 milliseconds

✔️ Checking and trying to unlock keyring works: https://drone.owncloud.com/owncloud/client/19477/2/10

--------------Scenario 1 (PASS)
LOG:   Start Scenario	login after logging out
LOG:   b false\n
...
LOG:   End Scenario	login after logging out

--------------Scenario 2 (PASS)
LOG:   Start Scenario	login after logging out
LOG:   Failed to get property Locked on interface org.freedesktop.Secret.Collection: Message recipient disconnected from message bus without replying	
LOG:   Unlocking keyring...
...
LOG:   End Scenario	login after logging out

@saw-jan saw-jan self-assigned this Sep 10, 2024
@saw-jan saw-jan force-pushed the tests/flaky-login-logout branch 7 times, most recently from 7f75087 to ddba4ab Compare September 17, 2024 06:43
@saw-jan saw-jan force-pushed the tests/flaky-login-logout branch 11 times, most recently from e200013 to 0365890 Compare September 24, 2024 06:27
@saw-jan saw-jan mentioned this pull request Sep 24, 2024
Merged
@saw-jan saw-jan force-pushed the tests/flaky-login-logout branch from 2aa9ccc to b5f4a52 Compare September 24, 2024 08:23
@saw-jan
Copy link
Member Author

saw-jan commented Sep 24, 2024

Unlocking keyring works: https://drone.owncloud.com/owncloud/client/19491/1/10

@saw-jan saw-jan force-pushed the tests/flaky-login-logout branch from b5f4a52 to 699c44c Compare September 24, 2024 09:45
@saw-jan
test: add all video files
365f831 
test: fix video file name

test: reverse video list
@saw-jan saw-jan force-pushed the tests/flaky-login-logout branch from 699c44c to 6b20861 Compare September 24, 2024 11:21
@saw-jan saw-jan changed the title [do-not-merge][gui-tests] check flaky login-logout test [gui-tests][full-ci] check the keyring and try to unlock if locked Sep 24, 2024
@saw-jan saw-jan force-pushed the tests/flaky-login-logout branch from 6b20861 to c20b7fa Compare September 24, 2024 11:24
@saw-jan saw-jan marked this pull request as ready for review September 24, 2024 12:07
@saw-jan
Copy link
Member Author

saw-jan commented Sep 24, 2024

Hopefully this won't come in the future 🤞

@saw-jan
Copy link
Member Author

saw-jan commented Sep 25, 2024

I will wait for GUI tests to get fixed (#11898) before merging it.

@saw-jan
Copy link
Member Author

saw-jan commented Sep 27, 2024

I want to merge this now because the tests are failing because of keyring thing. CI will not pass because of 11898.

@saw-jan saw-jan merged commit 4ca07fd into master Sep 27, 2024
6 checks passed
@saw-jan saw-jan deleted the tests/flaky-login-logout branch September 27, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@ishabaral ishabaral Awaiting requested review from ishabaral

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] GUI tests sometime fails due to the system keyring dialog
2 participants
@saw-jan @PrajwolAmatya