[FEATURE REQUEST] oCIS Light users #4518

joragua · 2024-11-26T07:36:14Z

Related Issues

App: #4490

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan:

Reports:

(1) No feedback in automatic uploads for User Light [FEATURE REQUEST] oCIS Light users #4518 (comment) [FIXED]
(2) Crash when user light copies file [FEATURE REQUEST] oCIS Light users #4518 (comment) [FIXED]
(3) Bad navigation in upload [FEATURE REQUEST] oCIS Light users #4518 (comment) [FIXED]
(4) List not displayed when sharing from 3rd party app [FEATURE REQUEST] oCIS Light users #4518 (comment)
(5) Account in automatic uploads are not set [FEATURE REQUEST] oCIS Light users #4518 (comment) [FIXED]

joragua · 2024-11-26T09:44:16Z

COMPLETED TASKS ✅

Added a condition to support light users in the login
Created a new fragment to show an empty folder in Personal tab
Disabled refresh from av. offline view
Updated drawer and manage accounts for light users
Modified automatic uploads for light users (if there are only light users, automatic uploads are disabled. On the other hand, light accounts are removed from accounts list)
Modified ReceiveExternalFiles
Added a new condition to avoid oCIS accounts warning dialog for light users

JuancaG05

Good job here @joragua! Some comments and questions before we proceed to QA 👍

changelog/unreleased/4518

owncloudApp/src/main/java/com/owncloud/android/MainApp.kt

...dApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainEmptyListFragment.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java

owncloudData/src/main/java/com/owncloud/android/data/spaces/repository/OCSpacesRepository.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

JuancaG05

LGTM, moving to QA!

jesmrec · 2024-11-28T11:57:37Z

(1) [FIXED]

Login with a User Light in oCIS
In Settings try to enable automatic uploads

Current:

Not posible, and no feedback why

Expected:

Not posible, but user should know why (snackbar, subtitle..)

Xiaomi Redmi Note 13
Android 14
69e545e34

joragua · 2024-11-28T12:27:27Z

(1) should be done with the last commit @jesmrec

jesmrec · 2024-11-28T12:27:42Z

(2) [FIXED]

User light with at least one space
Enter in the space and select Copy for any file -> list of spaces is displayed
Select any space

Current:

App crashes. This is the stacktrace:

FATAL EXCEPTION: main (Ask Gemini)
                 Process: com.owncloud.android.debug, PID: 21197
                 java.lang.ClassCastException: com.owncloud.android.ui.activity.FolderPickerActivity cannot be cast to com.owncloud.android.ui.activity.FileDisplayActivity
                 	at com.owncloud.android.presentation.files.filelist.MainFileListFragment$subscribeToViewModels$1.invokeSuspend(MainFileListFragment.kt:319)
                 	at com.owncloud.android.presentation.files.filelist.MainFileListFragment$subscribeToViewModels$1.invoke(Unknown Source:8)
                 	at com.owncloud.android.presentation.files.filelist.MainFileListFragment$subscribeToViewModels$1.invoke(Unknown Source:4)
                 	at kotlinx.coroutines.flow.FlowKt__MergeKt$mapLatest$1.invokeSuspend(Merge.kt:214)
                 	at kotlinx.coroutines.flow.FlowKt__MergeKt$mapLatest$1.invoke(Unknown Source:13)
                 	at kotlinx.coroutines.flow.FlowKt__MergeKt$mapLatest$1.invoke(Unknown Source:4)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3$1$2.invokeSuspend(Merge.kt:34)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3$1$2.invoke(Unknown Source:8)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3$1$2.invoke(Unknown Source:4)
                 	at kotlinx.coroutines.intrinsics.UndispatchedKt.startCoroutineUndispatched(Undispatched.kt:55)
                 	at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:112)
                 	at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126)
                 	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56)
                 	at kotlinx.coroutines.BuildersKt.launch(Unknown Source:1)
                 	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:47)
                 	at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source:1)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3$1.emit(Merge.kt:33)
                 	at kotlinx.coroutines.flow.StateFlowImpl.collect(StateFlow.kt:398)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3.invokeSuspend(Merge.kt:27)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3.invoke(Unknown Source:8)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest$flowCollect$3.invoke(Unknown Source:4)
                 	at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:89)
                 	at kotlinx.coroutines.CoroutineScopeKt.coroutineScope(CoroutineScope.kt:264)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowTransformLatest.flowCollect(Merge.kt:25)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowOperator.collectTo$suspendImpl(ChannelFlow.kt:157)
                 	at kotlinx.coroutines.flow.internal.ChannelFlowOperator.collectTo(Unknown Source:0)
                 	at kotlinx.coroutines.flow.internal.ChannelFlow$collectToFun$1.invokeSuspend(ChannelFlow.kt:60)
                 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
                 	at kotlinx.coroutines.EventLoop.processUnconfinedEvent(EventLoop.common.kt:69)
                 	at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:376)
                 	at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:30)
                 	at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable$default(Cancellable.kt:25)
                 	at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:110)
                 	at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:126)
                 	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56)
                 	at kotlinx.coroutines.BuildersKt.launch(Unknown Source:1)
                 	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:47)
                 	at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source:1)
                 	at androidx.lifecycle.RepeatOnLifecycleKt$repeatOnLifecycle$3$1$1$1.onStateChanged(RepeatOnLifecycle.kt:106)
                 	at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.java:360)
                 	at androidx.lifecycle.LifecycleRegistry.forwardPass(LifecycleRegistry.java:271)
13:21:27.651  E  	at androidx.lifecycle.LifecycleRegistry.sync(LifecycleRegistry.java:313) (Ask Gemini)
                 	at androidx.lifecycle.LifecycleRegistry.moveToState(LifecycleRegistry.java:151)
                 	at androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent(LifecycleRegistry.java:134)
                 	at androidx.fragment.app.Fragment.performStart(Fragment.java:3176)
                 	at androidx.fragment.app.FragmentStateManager.start(FragmentStateManager.java:588)
                 	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:279)
                 	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1901)
                 	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1819)
                 	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1762)
                 	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:547)
                 	at android.os.Handler.handleCallback(Handler.java:958)
                 	at android.os.Handler.dispatchMessage(Handler.java:99)
                 	at android.os.Looper.loopOnce(Looper.java:224)
                 	at android.os.Looper.loop(Looper.java:318)
                 	at android.app.ActivityThread.main(ActivityThread.java:8763)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)
                 	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@17a752, Dispatchers.Main.immediate]

Expected:

No crash

Xiaomi Redmi Note 13
Android 14
69e545e34

jesmrec · 2024-11-28T13:05:36Z

(3) [FIXED]

Related with navigation

A user light with edit permissions enters in any space with edit permissions
Click on FAB -> Upload
Upload some files

Current:

Personal is displayed (the new fragment), but Spaces selected in the bottom bar:

Screen_recording_20241128_140154.mp4

Expected:

Space's list of files is displayed with the new files uploaded

NOTE: Also reproducible with regular users, and not in master

Xiaomi Redmi Note 13
Android 14
254d09323

jesmrec · 2024-11-29T08:46:53Z

(4)

maybe related with (3)

Enter in a 3rd party app
Share something with any user (light or not), inside an space (not Personal)

Current:

empty list in the picker, but not in every space of every account... that's strange

Screen_recording_20241129_094551.mp4

Expected:

list of files inside the space is displayed.

Xiaomi Redmi Note 13
Android 14
b064986

jesmrec · 2024-11-29T09:23:13Z

Note that (4) is also reproducible in current master, so it's not something from this PR and does not need to be fixed here.

It is not reproducible in stable so this is a regression that must be fixed in the scope of the current version.

jesmrec · 2024-11-29T13:54:45Z

(5) [FIXED]

Add two accounts: user light and regular user
Go to Settings and enable automatic uploads

Current:

Account to upload pictures as Not set .

Expected:

One account should be set as target when automatic uploads are enabled. Otherwise, the uploads will not have a target to upload and fail with a non-recoverable Connection error

Xiaomi Redmi Note 13
Android 14
b064986

…able condition for spaces header

… accounts dialog

…ht users

…nges

… light users

…amed one method in `FileDisplayActivity`

…t user

…e account is set)

…ced light users by users light in release notes

…nd `FolderPickerActivity` for refresh operation

…en the quota is updated

joragua · 2024-12-02T10:35:33Z

(2) (3) and (5) should be fixed @jesmrec

…and removed unnecessary check for refresh operation

…rs light

joragua self-assigned this Nov 26, 2024

joragua changed the title ~~[FEATURE] oCIS Light Users~~ [FEATURE REQUEST] oCIS Light Users Nov 26, 2024

joragua linked an issue Nov 26, 2024 that may be closed by this pull request

[FEATURE REQUEST] oCIS Light users #4490

Open

18 tasks

joragua force-pushed the feature/light_users branch 2 times, most recently from c8cdae3 to c193f02 Compare November 26, 2024 09:26

joragua requested a review from JuancaG05 November 26, 2024 09:45

joragua marked this pull request as ready for review November 26, 2024 09:46

JuancaG05 changed the title ~~[FEATURE REQUEST] oCIS Light Users~~ [FEATURE REQUEST] oCIS Light users Nov 27, 2024

JuancaG05 requested changes Nov 27, 2024

View reviewed changes

joragua requested a review from JuancaG05 November 28, 2024 10:07

joragua force-pushed the feature/light_users branch 3 times, most recently from 8273a93 to 9791efb Compare November 28, 2024 10:55

JuancaG05 approved these changes Nov 28, 2024

View reviewed changes

joragua force-pushed the feature/light_users branch from f739c47 to 69e545e Compare November 28, 2024 11:01

joragua force-pushed the feature/light_users branch 2 times, most recently from dcfb6b8 to 28cf5de Compare November 29, 2024 13:50

joragua added 5 commits December 2, 2024 10:42

feat: added new condition in the login to support light users

afdfb47

feat: added new main fragment (MainEmptyListFragment) for light users

64ab6f3

feat: disabled refresh operation for av.offline view and removed null…

3e02b60

…able condition for spaces header

feat: added new condition to support light users in drawer and manage…

dae2f5a

… accounts dialog

feat: disabled light users for automatic uploads

08d277a

joragua added 15 commits December 2, 2024 10:42

feat: adapted ReceiveExternalFiles (Activity and ViewModel) for lig…

7b35c2e

…ht users

feat: added release note

05b9792

chore: added calens file

128d329

refactor: removed unnecessary get in ViewModelModule and Ktlint cha…

d8989c3

…nges

feat: added a new condition to avoid oCIS accounts warning dialog for…

404a357

… light users

refactor: changed the content of calens file and release note and ren…

ef06698

…amed one method in `FileDisplayActivity`

refactor: replaced the use case for checking if the account is a ligh…

b4893f7

…t user

feat: removed search in toolbar for light users

6b06f7a

refactor: removed one unnecessary method from automatic uploads

35f5fa1

refactor: moved ReceiveExternalFilesViewModel creation (now when th…

824294e

…e account is set)

refactor: removed unnecessary code in toolbar for light users

157264e

refactor: added identation in DrawerActivity

2b15213

feat: added a snackbar in automatic uploads for light users and repla…

1f953dd

…ced light users by users light in release notes

fix: added a condition to distinguish between FileDisplayActivity a…

af6ddc6

…nd `FolderPickerActivity` for refresh operation

fix: created a new method in 'DrawerViewModel' to avoid navigation wh…

9832da9

…en the quota is updated

joragua force-pushed the feature/light_users branch 2 times, most recently from 679c9c7 to bf814d7 Compare December 2, 2024 09:47

fix: set an account by default when automatic uploads are enabled

98ebf7c

joragua force-pushed the feature/light_users branch from 431679c to 98ebf7c Compare December 2, 2024 10:31

docs: calens changelog updated

70e6e98

joragua added 2 commits December 3, 2024 10:22

refactor: moved checkUserLight method to ManageAccountsViewModel …

1c13299

…and removed unnecessary check for refresh operation

fix: set the correct account for automatic uploads when there are use…

4f3409b

…rs light

joragua force-pushed the feature/light_users branch from 31646a7 to 4f3409b Compare December 3, 2024 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE REQUEST] oCIS Light users #4518

[FEATURE REQUEST] oCIS Light users #4518

joragua commented Nov 26, 2024 •

edited by jesmrec

Loading

joragua commented Nov 26, 2024 •

edited

Loading

JuancaG05 left a comment

JuancaG05 left a comment

jesmrec commented Nov 28, 2024 •

edited

Loading

joragua commented Nov 28, 2024

jesmrec commented Nov 28, 2024 •

edited

Loading

jesmrec commented Nov 28, 2024 •

edited

Loading

jesmrec commented Nov 29, 2024 •

edited

Loading

jesmrec commented Nov 29, 2024

jesmrec commented Nov 29, 2024 •

edited

Loading

joragua commented Dec 2, 2024

[FEATURE REQUEST] oCIS Light users #4518

Are you sure you want to change the base?

[FEATURE REQUEST] oCIS Light users #4518

Conversation

joragua commented Nov 26, 2024 • edited by jesmrec Loading

Related Issues

QA

joragua commented Nov 26, 2024 • edited Loading

COMPLETED TASKS ✅

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

jesmrec commented Nov 28, 2024 • edited Loading

(1) [FIXED]

joragua commented Nov 28, 2024

jesmrec commented Nov 28, 2024 • edited Loading

(2) [FIXED]

jesmrec commented Nov 28, 2024 • edited Loading

(3) [FIXED]

jesmrec commented Nov 29, 2024 • edited Loading

(4)

jesmrec commented Nov 29, 2024

jesmrec commented Nov 29, 2024 • edited Loading

(5) [FIXED]

joragua commented Dec 2, 2024

joragua commented Nov 26, 2024 •

edited by jesmrec

Loading

joragua commented Nov 26, 2024 •

edited

Loading

jesmrec commented Nov 28, 2024 •

edited

Loading

jesmrec commented Nov 28, 2024 •

edited

Loading

jesmrec commented Nov 28, 2024 •

edited

Loading

jesmrec commented Nov 29, 2024 •

edited

Loading

jesmrec commented Nov 29, 2024 •

edited

Loading