Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Lint reports an error #4485

Open
hannesa2 opened this issue Oct 2, 2024 · 1 comment
Open

[BUG] Lint reports an error #4485

hannesa2 opened this issue Oct 2, 2024 · 1 comment
Labels
Milestone

Comments

@hannesa2
Copy link
Contributor

hannesa2 commented Oct 2, 2024

I guess you don't run lint during the pull request pipeline, otherwise you would see during

./gradlew :owncloudApp:lintDebug

this

              Lint found 1 errors, 847 warnings. First failure:

/Users/hannes/git/owncloud-android/owncloudApp/src/main/java/com/owncloud/android/extensions/FragmentExt.kt:89: Error: Wrong usage of repeatOnLifecycle from ManageAccountsDialogFragment.onStart. [RepeatOnLifecycleWrongUsage from androidx.lifecycle]
repeatOnLifecycle(lifecycleState) {
^

 Explanation for issues of type "RepeatOnLifecycleWrongUsage":
 The repeatOnLifecycle APIs should be used when the View is created,        
         that is in the onCreate lifecycle method for Activities, or
 onViewCreated in                 case you're using Fragments.

 Vendor: Android Open Source Project
 Identifier: androidx.lifecycle
 Feedback: https://issuetracker.google.com/issues/new?component=413132
@jesmrec
Copy link
Collaborator

jesmrec commented Oct 2, 2024

About the warnings, we are working in adding an static code analyzer to the CI system. We hope it'll be ready soon to help to avoid/fix such amount of warnings.

Will take a look to the error.

Thanks for reporting

@JuancaG05 JuancaG05 changed the title [BUG]Lint reports an error [BUG] Lint reports an error Oct 3, 2024
@jesmrec jesmrec added this to the Backlog milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants