feat: add dependency for detekt-rules-libraries and add available fie…

…lds to detekt.yml file
owncloud · Nov 20, 2024 · b96e246 · b96e246
1 parent 3b8ee2c
commit b96e246
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 0 deletions.
diff --git a/config/detekt/detekt.yml b/config/detekt/detekt.yml
@@ -282,6 +282,17 @@ exceptions:
       - 'RuntimeException'
       - 'Throwable'
 
+libraries:
+  active: true
+  ForbiddenPublicDataClass:
+    active: true
+    ignorePackages: ['*.internal', '*.internal.*']
+  LibraryCodeMustSpecifyReturnType:
+    active: true
+    allowOmitUnit: false
+  LibraryEntitiesShouldNotBePublic:
+    active: true
+
 naming:
   active: true
   BooleanPropertyNaming:

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -81,6 +81,7 @@ androidx-test-runner = { group = "androidx.test", name = "runner", version.ref =
 androidx-test-uiautomator = { group = "androidx.test.uiautomator", name = "uiautomator", version.ref = "androidxTestUiAutomator" }
 androidx-work-runtime-ktx = { group = "androidx.work", name = "work-runtime-ktx", version.ref = "androidxWork" }
 coil = { group = "io.coil-kt", name = "coil", version.ref = "coil" }
+detekt-libraries = { module = "io.gitlab.arturbosch.detekt:detekt-rules-libraries", version.ref = "detekt" }
 dexopener = { group = "com.github.tmurakami", name = "dexopener", version.ref = "dexopener" }
 disklrucache = { group = "com.jakewharton", name = "disklrucache", version.ref = "disklrucache" }
 media3-exoplayer = { group = "androidx.media3", name = "media3-exoplayer", version.ref = "media3" }

diff --git a/owncloudApp/build.gradle b/owncloudApp/build.gradle
@@ -85,6 +85,9 @@ dependencies {
     debugImplementation libs.androidx.fragment.testing
     debugImplementation libs.androidx.test.monitor
     debugImplementation libs.stetho
+
+    // Detekt
+    detektPlugins libs.detekt.libraries
 }
 
 android {

diff --git a/owncloudComLibrary/build.gradle b/owncloudComLibrary/build.gradle
@@ -26,6 +26,9 @@ dependencies {
     testImplementation 'junit:junit:4.13.2'
     testImplementation 'org.robolectric:robolectric:4.10'
     debugImplementation 'com.facebook.stetho:stetho-okhttp3:1.6.0'
+
+    // Detekt
+    detektPlugins libs.detekt.libraries
 }
 
 android {

diff --git a/owncloudData/build.gradle b/owncloudData/build.gradle
@@ -89,4 +89,7 @@ dependencies {
     androidTestImplementation libs.androidx.test.runner
     androidTestImplementation libs.kotlinx.coroutines.test
     androidTestImplementation(libs.mockk.android) { exclude module: "objenesis" }
+
+    // Detekt
+    detektPlugins libs.detekt.libraries
 }
diff --git a/owncloudDomain/build.gradle b/owncloudDomain/build.gradle
@@ -45,4 +45,7 @@ dependencies {
     testImplementation libs.junit4
     testImplementation libs.kotlinx.coroutines.test
     testImplementation libs.mockk
+
+    // Detekt
+    detektPlugins libs.detekt.libraries
 }
diff --git a/owncloudTestUtil/build.gradle b/owncloudTestUtil/build.gradle
@@ -33,4 +33,7 @@ dependencies {
     implementation project(':owncloudComLibrary')
     implementation libs.kotlin.stdlib
     implementation libs.androidx.lifecycle.livedata.ktx
+
+    // Detekt
+    detektPlugins libs.detekt.libraries
 }