Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Token Auras #82

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

SeamusFinlayson
Copy link
Contributor

@SeamusFinlayson SeamusFinlayson commented Oct 17, 2024

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234
Copy link
Collaborator

Validation script and image URLs check out fine. Extension functionality and API usage not checked.

Copy link
Contributor

@nthouliss nthouliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of thing:

  • Could you make the homepage_url in the manifest go to the extension github instead?
  • The aura doesn't take image alignment into account, the aura isn't centred if the image alignment isn't in the top left

@SeamusFinlayson
Copy link
Contributor Author

SeamusFinlayson commented Oct 28, 2024

  • Oops, forgot to add the repo
  • Alignment should now be accounted for, as well as rotation and scale

Copy link
Contributor

@nthouliss nthouliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think you could make this a little more mobile-friendly by changing the UI to take a little more horizontal space rather than vertical but that's just general feedback :)

@nthouliss nthouliss merged commit 760a1e9 into owlbear-rodeo:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified by human verified by a person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants