-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NPC Generator #81
base: main
Are you sure you want to change the base?
Conversation
Been editing the main by accident and usure if reflect here - if so - will resubmit with 1 squashed version over the weekend |
Should all be updated now |
Hi guys - appreciate you're busy - think this is all up-to-date... I'll respond pretty rapidly otherwise 👍 |
Hi James, I've just run the verification script and it threw an error with your use of tags (because we don't currently have either 'roleplay' or 'character' options in the list of supported tags). Can you remove those please? Otherwise, it looks ready to pass that verification step, then on to Nicola... |
Awesome... Thank you! Get that sorted in the morning 🙌 |
All sorted ;-) |
Validation script and image URLs check out fine. Extension functionality and API usage not checked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor change which would be to lessen the logs in the dev console. Clicking generate a few times pollutes the console a little. You also need to squash your commits.
Just as general feedback (not a requirement for submission):
- There's a lot of scrolling involved to get to the what you're supposed to use the extension for. I don't think you need the DnD Realm Creator text when you already have a logo. I would probably remove the huge stack of buttons and change it to something like a selection drop-down, it would reduce the vertical space a lot. You probably don't need the Patreon QR code at the bottom all the time. You could put this under your Patreon selection (or just have a link to the Patreon under this section instead of a QR code).
I've also noticed that your store page mentions the version (i.e. NPC-Generator-OBR-1.0.4
), do you want to do this? You'd have to resubmit if you're tying the store page to a version
Hey Nicola... Great, will definitely make those changes! Got super lazy with it being 1 file... The updates I am gonna 💯 change. Thank you so much by the way guys, really appreciate it!! 🎉 🙌 James 🙌 |
Make sure that your submission has the following:
Please, go through these steps before you submit a PR.
You have done your changes in a separate branch.
You have a descriptive commit message with a short title (first line).
You have only one commit (if not, squash them into one commit).
Your pull request MUST target the
main
branch on this repository.Your pull request puts your extensions details as the last entry in the extensions.json file