Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fog-painter #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add fog-painter #76

wants to merge 1 commit into from

Conversation

davidsev
Copy link
Contributor

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234
Copy link
Collaborator

Validation script and image URLs check out fine. Extension functionality and API usage not checked.

Copy link
Contributor

@nthouliss nthouliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I'd request for the tool is to allow unselect on the fog brush tool when selecting the icon again (so if it's currently selected, clicking again removes the brush size option like how the fog style tool works).

Just as a general piece of feedback the documentation makes it seem like using the tool will automatically reveal the fog but this only happens when fog cutting is enabled. This is fine (and probably preferred) but it might be good to clarify this in the docs.

@davidsev
Copy link
Contributor Author

davidsev commented Nov 2, 2024

Thanks for the feedback, those issues have now been resolved.

@nthouliss
Copy link
Contributor

Thanks! The only thing is now the fog brush tool can't be toggled on again 😅

Reproduction goes:

  1. Select fog paint brush (the brush size bar is now open)
  2. Select fog paint brush again (the brush size bar is now closed)
  3. Select paint brush a third time (the bar doesn't open)

Sorry, it's a bit of a picky one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants