Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phases automated to the store #69

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

SeamusFinlayson
Copy link
Contributor

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234
Copy link
Collaborator

Several-Record7234 commented Aug 14, 2024

Hey, there's a minor issue with your store.md contents:

  1. in the Support section, the Discord link is an older one that has now been removed, instead please use the official link found at the foot of this page (under the Community heading) https://docs.owlbear.rodeo/extensions/getting-started

Thanks!

Andrew.

@SeamusFinlayson
Copy link
Contributor Author

Fixed!

@Several-Record7234
Copy link
Collaborator

Validation script and image URLs check out fine. Extension functionality and API usage not checked.

@nthouliss nthouliss self-requested a review as a code owner October 14, 2024 01:08
Copy link
Contributor

@nthouliss nthouliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I will say I think the check boxes are confusing. I think it would be more valuable to have a selectable dropdown with the options and then the user can select a trashcan icon to delete the property to remove it, it prevents the user from just toggling them all the time and ruining the automation.

@nthouliss nthouliss merged commit 408dccc into owlbear-rodeo:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified by human verified by a person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants