Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Decked! to OBR Store #66

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

ManuelLovell
Copy link
Contributor

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234
Copy link
Collaborator

Several-Record7234 commented Aug 14, 2024

Hey, there may be a few issues with your store.md contents:

  1. https://battle-system.com/owlbear/decked-docs/preview.png doesn't work in-browser for me, I'm getting a 404 error
  2. https://battle-system.com/owlbear/chronicle-docs/logo.png also doesn't work in-browser for me, another 404 error
  3. in the Support section, the Discord link is an older one that has now been removed, please use this official link instead <redacted because bots>

Thanks!

Andrew.

@ManuelLovell
Copy link
Contributor Author

ManuelLovell commented Aug 14, 2024

Hey, there may be a few issues with your store.md contents:

  1. https://battle-system.com/owlbear/decked-docs/preview.png doesn't work in-browser for me, I'm getting a 404 error
  2. https://battle-system.com/owlbear/chronicle-docs/logo.png also doesn't work in-browser for me, another 404 error
  3. in the Support section, the Discord link is an older one that has now been removed, please use this official link instead <redacted because bots>

Thanks!

Andrew.

Noted - the preview image was a WEBP, not PNG - so I updated the link.
The logo image (I assume you meant for decked) was missing, so it's been added.
I updated the Discord link for every readme file.

Thanks for the check-in!

@Several-Record7234
Copy link
Collaborator

Yep, noob error from me as I copied and pasted a prior message!

Noted - the preview image was a WEBP, not PNG - so I updated the link. The logo image (I assume you meant for decked) was missing, so it's been added. I updated the Discord link for every readme file.

Thanks for the check-in!

@Several-Record7234
Copy link
Collaborator

Validation script and image URLs check out fine. Extension functionality and API usage not checked.

@nthouliss
Copy link
Contributor

I'd recommend changing the tag to other

@ManuelLovell
Copy link
Contributor Author

I'd recommend changing the tag to other

Updated also.

@nthouliss nthouliss self-requested a review as a code owner August 26, 2024 04:54
@nthouliss nthouliss merged commit c8e4821 into owlbear-rodeo:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified by human verified by a person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants