Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Map Location Keys #61

Closed
wants to merge 3 commits into from

Conversation

alvarocavalcanti
Copy link
Contributor

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@nthouliss
Copy link
Contributor

These are our supported tags which can be used with the exception of built-by-owlbear in your case.

https://github.com/owlbear-rodeo/extensions/blob/main/tags.json

@alvarocavalcanti
Copy link
Contributor Author

These are our supported tags which can be used with the exception of built-by-owlbear in your case.

https://github.com/owlbear-rodeo/extensions/blob/main/tags.json

Fixed!

@nthouliss
Copy link
Contributor

Cool! Thank you, I'd probably put your extension under the tool tag and remove the other tag but other is acceptable if you want.

The help sections are great, I would probably add a blur on your room link in your help video in the extension (the URL is visible in the chrome browser that you screen recorded) just to prevent any possible spam. You should be able to do this in YouTube so you don't have to re-upload the video. Deleting the room is also an option.

Once you let me know that the room has been deleted or the video edited then I'm happy to approve for the store :)

@alvarocavalcanti
Copy link
Contributor Author

Thanks for the feedback. I've switched to the tool tag as recommended and also added a blur to the URLs in both videos, but it might take a while to be fully applied, thanks for the tip!

@nthouliss
Copy link
Contributor

@alvarocavalcanti This should be ready to accept, could you please squash your commits into one?

@alvarocavalcanti
Copy link
Contributor Author

Messed up with the rebase, I will close this and open a new one.

@alvarocavalcanti
Copy link
Contributor Author

Created #67 as a replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants