Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Dragonbane Initiative #54

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Adds Dragonbane Initiative #54

merged 2 commits into from
Jul 31, 2024

Conversation

nboughton
Copy link

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@nthouliss
Copy link
Contributor

Hi @nboughton! Thanks for your patience I know it's been a while since you submitted.

I'm having some trouble with your links. The images and the learn more page resolves to a 404.

There's also a small bug with initiative appearing between refreshes. If I have some tokens, add them to initiative, draw initiative and then refresh the page the initiative won't appear. I can see that the extension does remember what tokens had initiative because if I click draw initiative again then the tokens appear (but with new initiative).

@nboughton
Copy link
Author

nboughton commented May 30, 2024

Hi @nboughton! Thanks for your patience I know it's been a while since you submitted.

I'm having some trouble with your links. The images and the learn more page resolves to a 404.

There's also a small bug with initiative appearing between refreshes. If I have some tokens, add them to initiative, draw initiative and then refresh the page the initiative won't appear. I can see that the extension does remember what tokens had initiative because if I click draw initiative again then the tokens appear (but with new initiative).

Thanks for the response :) I've modified the store.md and rsync'd a new build to my server. I'm not sure what the best way to fix the reload bug is. The initiative list is setup here: https://github.com/nboughton/obr-dragonbane-initiative/blob/main/src/lib/initiativeList.ts

Is there a recommended best practice to ensure the data loads correctly on page reload?

For the moment I've added the following to the setup function:

 OBR.scene.items.updateItems((item): item is Item => (item.metadata[IDs.Meta] ? true : false), renderList);

Which I believe should trigger the render.

@nthouliss
Copy link
Contributor

@mitchemmc is probably best to ask about best practise, especially in regards to the OBR SDK.

I can see that the list does persist on a re-render.

I'm still getting a 404 on the image and the icon:

https://nboughton.uk/apps/obr-db-initiative/image.png
https://nboughton.uk/apps/obr-db-initiative/cards.svg

@nboughton
Copy link
Author

@mitchemmc is probably best to ask about best practise, especially in regards to the OBR SDK.

I can see that the list does persist on a re-render.

I'm still getting a 404 on the image and the icon:

https://nboughton.uk/apps/obr-db-initiative/image.png https://nboughton.uk/apps/obr-db-initiative/cards.svg

Those links are pointing to the wrong path (mistake on my part), they are fixed in the current version of the store.md that's linked in the pull request.

@nthouliss
Copy link
Contributor

Those links are pointing to the wrong path (mistake on my part), they are fixed in the current version of the store.md that's linked in the pull request.

Those links are still not working in the store page that I am checking.

https://nboughton.uk/apps/obr-db-initiative/image.png
https://nboughton.uk/apps/obr-db-initiative/cards.svg

@nboughton
Copy link
Author

nboughton commented Jul 11, 2024

Hi Nicola,
It turns out I'm an idiot and totally missed the links at the top of the store.md that were wrong!

I've amended the file and uploaded the new build to my site. So sorry about the misunderstanding!

@nthouliss nthouliss merged commit 66eccbf into owlbear-rodeo:main Jul 31, 2024
@nthouliss
Copy link
Contributor

All good! I should have clarified, thanks for your patience as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants