Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Calendar of Harptos' extension #53

Merged
merged 2 commits into from
May 17, 2024

Conversation

resident-uhlig
Copy link
Contributor

@resident-uhlig resident-uhlig commented Mar 15, 2024

There is already a calendar extension. But it seems not to be comaptible with the specifics of the Calendar of Harptos, e. g. Festivals between months. So I have created my own extension for that.

My markdown file is not hosted on GitHub but there are other extensions not hosted on GitHub aswell. I hope that's fine.

NB: Is it worth to have a tag "calendar"?

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@nthouliss
Copy link
Contributor

NB: Is it worth to have a tag "calendar"?

We'll have a think on it but I'm not sure if two extensions are enough to justify a new category for it.

You extension is good for store submission but it might be worth making the links open in a new tab rather than redirect the user away from the room (which could be annoying in the middle of a game).

You also have this little question mark that pops up when you hover over the moon phase. I'm not sure what this is supposed to do as interacting with it doesn't show anything.

It might be worth thinking about only changing the date or time once the user hits enter or presses a button. As a GM I might not want all my fiddling around to be shown to the player 😄

I also see that you mention using local storage to store per-user settings. This is exactly what you're supposed to be doing, as player metadata is not meant to be persisted between refreshes (I also responded to your issue).

Your store page is great by the way, I don't always get nice instructions on how the extension works.

@nthouliss nthouliss merged commit 6968c6c into owlbear-rodeo:main May 17, 2024
@resident-uhlig
Copy link
Contributor Author

Thanks the feedback. :) I got some questions, though.

it might be worth making the links open in a new tab

Which links do you mean? The links for "Strong Wind" etc. have target="_blank" and should open in a new window/tab.

You also have this little question mark that pops up when you hover over the moon phase. I'm not sure what this is supposed to do as interacting with it doesn't show anything.

It should show a tooltip (the title attribute.) Which browser, language, and date did you use?

image

@nthouliss
Copy link
Contributor

It should show a tooltip (the title attribute.) Which browser, language, and date did you use?

I'm using Chrome with English, is it a hover event? It seems to be working okay now, maybe I was just impatient and didn't wait long enough ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants