-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dashboard-maker to extensions.json #43
add dashboard-maker to extensions.json #43
Conversation
Looks great! Only a few things on my end. The 'other' tag should only be used in the case that none of the tags match your use-case. In your case I don't think this would be classified as a tool, so the 'other' tag is the most appropriate. This doesn't affect your submission but it might be helpful to have a small video of your extension to show how to edit the character dashboard. |
@nthouliss I went ahead and removed the "tool" tag from my Let me know if any other changes are needed! |
Actually, I do want to check one thing tomorrow...I want to make sure that my use of localforage wouldn't interfere with any other use of localforage from any other extension. I need to namespace the db store it create for my app, I think. Let me play with that before you merge, if you don't mind. I should have it figured out sometime tomorrow. |
@nthouliss ok, fixed. Ready to go when you are 😄 |
@nthouliss just checking back on this PR. Is there anything else needed? |
@nthouliss I'm realizing after merging that the image references in my I've already fixed it on my end. Will that just auto-update after some time on the owlbear page? This page here: https://extensions.owlbear.rodeo/dashboard-maker |
@RobertTate I jumped on to let you know, I should have been more thorough when checking the images. I've triggered a redeployment now and it should be fixed on the extension store when it's completed |
Thanks! |
Make sure that your submission has the following:
Please, go through these steps before you submit a PR.
You have done your changes in a separate branch.
You have a descriptive commit message with a short title (first line).
You have only one commit (if not, squash them into one commit).
Your pull request MUST target the
main
branch on this repository.Your pull request puts your extensions details as the last entry in the extensions.json file