Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dashboard-maker to extensions.json #43

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

RobertTate
Copy link
Contributor

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@nthouliss
Copy link
Contributor

Looks great! Only a few things on my end.

The 'other' tag should only be used in the case that none of the tags match your use-case. In your case I don't think this would be classified as a tool, so the 'other' tag is the most appropriate.

This doesn't affect your submission but it might be helpful to have a small video of your extension to show how to edit the character dashboard.

@RobertTate
Copy link
Contributor Author

@nthouliss I went ahead and removed the "tool" tag from my store.md file, and make my best attempt to add a gif as the hero image, per your recommendation.

Let me know if any other changes are needed!

@RobertTate
Copy link
Contributor Author

Actually, I do want to check one thing tomorrow...I want to make sure that my use of localforage wouldn't interfere with any other use of localforage from any other extension. I need to namespace the db store it create for my app, I think.

Let me play with that before you merge, if you don't mind. I should have it figured out sometime tomorrow.

@RobertTate
Copy link
Contributor Author

@nthouliss ok, fixed. Ready to go when you are 😄

@RobertTate
Copy link
Contributor Author

@nthouliss just checking back on this PR. Is there anything else needed?

@nthouliss nthouliss merged commit 9f21046 into owlbear-rodeo:main Dec 11, 2023
@RobertTate
Copy link
Contributor Author

@nthouliss I'm realizing after merging that the image references in my store.md file were using relative paths to the images. It seems I need to use the absolute paths of the images that were already uploaded.

I've already fixed it on my end. Will that just auto-update after some time on the owlbear page?

This page here: https://extensions.owlbear.rodeo/dashboard-maker

@nthouliss
Copy link
Contributor

@RobertTate I jumped on to let you know, I should have been more thorough when checking the images. I've triggered a redeployment now and it should be fixed on the extension store when it's completed

@RobertTate
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants