Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite getRelatedChartsForVariable query #3203

Closed
mlbrgl opened this issue Feb 15, 2024 · 1 comment
Closed

refactor: rewrite getRelatedChartsForVariable query #3203

mlbrgl opened this issue Feb 15, 2024 · 1 comment
Labels
feature needs triage site

Comments

@mlbrgl
Copy link
Member

mlbrgl commented Feb 15, 2024

This is an optimization of the query listing related charts on data pages.

I think it's better to join on the chart_dimensions table rather than this json_contains (normal tables are much faster to filter than nested json in MySQL)

Raised by @danyx23 in #3176 (comment)
@mlbrgl mlbrgl mentioned this issue Feb 15, 2024
Merged
16 tasks
@ikesau
Copy link
Member

ikesau commented Mar 27, 2024

Not a big enough of a perf hit to ever be a priority, realistically

@ikesau ikesau closed this as completed Mar 27, 2024
@larsyencken larsyencken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature needs triage site
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larsyencken @ikesau @mlbrgl