Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split by country option disappears if a short axis unit is added and relative values is off #2939

Closed
saloni-nd opened this issue Nov 24, 2023 · 1 comment

Comments

@saloni-nd
Copy link

saloni-nd commented Nov 24, 2023

Description

Split by country isn't shown if a short axis unit is added, unless relative values is on.

Expected behaviour

I expected split by country to be available regardless of having a short axis unit, and regardless of having relative values.

Steps to reproduce and screenshots

Steps to reproduce the behavior:

This chart has weird behaviour when I enter a short axis unit – the 'split by country' option disappears, and it switches to 'split by metric'.

After that, if I turn on 'relative values', then 'split by country' shows up again.

Screenshots

Initial chart:

image

If I add a short axis unit, it switches automatically to 'split by metric':

image

And the 'split by country' option disappears:

image

But if I turn on 'relative values', then the 'split by country' option shows up again:

image

Screen capture video

Not sure if I can upload a video here but maybe it works:

Screen.Recording.2023-11-23.at.22.49.25.mov

Environment

In owid.cloud

Additional context

Add any other context about the problem here.

@danyx23
Copy link
Contributor

danyx23 commented Feb 14, 2024

@saloni-nd this took us a while to understand but what is going on here is that by changing the short unit of just one indicator you are making them "not the same". If you set the same short unit on all indicators, the split by country option becomes the default again and it works as intended.

This is admittedly hard to understand but it's not clear to us how best to avoid this - we probably need this check to make sure that showing the data facetted like this is sensible in the first place. As such, I'll close it as wont-fix and we'll have to try to educate others about this.

@danyx23 danyx23 closed this as completed Feb 14, 2024
@larsyencken larsyencken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants