Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorers show no data when variable IDs or csv file URLs change after a dataset update #2937

Open
pabloarosado opened this issue Nov 23, 2023 · 3 comments
Labels
bug explorers ops Devops related issues (stagings servers, ...) priority 3 - nice to have

Comments

@pabloarosado
Copy link
Contributor

Description

Indicator-based and csv-based explorers rely on variable IDs and csv file URLs. When they change, they may silently start showing no data and we have no way to know.

Expected behaviour

We should be warned when an indicator-based explorer is relying on indicators or csv files that do not exist anymore (or even better, also when they are not the last version).

Additional context

In an ideal world, we should rethink how the inputs of explorer tsv files should be defined, but, given that this year we are probably not going to create many explorers, for now, at least, we should be aware when an explorer fails to load data.

@ikesau
Copy link
Member

ikesau commented Feb 27, 2024

There are a few places we could try to address this:

  1. Add validation in mirror_explorers
  2. Add validation during baking
  3. Add better bugsnag reporting when an explorer tries to load a variable via an invalid ID
  • Potentially hard to reliably narrow down to this specific failure case when loading can fail due to wifi/firewalls/etc

@pabloarosado
Copy link
Contributor Author

On the ETL side, one thing we can do (and is happening already for several explorers) is to use version latest (instead of a date) on explorer steps. This way, nothing needs to be changed on csv-based explorers. So, if the data changes in ETL, the URL to the csv file feeding the explorer will be the same, and therefore the data in the explorer will change automatically.

This avoids the problem of csv-based explorers showing no data, but it doesn't solve the problem for indicator-based explorers.

@danyx23 danyx23 added ops Devops related issues (stagings servers, ...) and removed data labels Mar 12, 2024
@sophiamersmann
Copy link
Member

#3552 added bugsnag reporting when an explorer with missing variables is baked. given that we have a solution for csv-based explorers on the data side and bugsnag reporting for indicator-based explorers, I'll downgrade the priority of this issue (but keeping it open to acknowledge that we could do more work here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug explorers ops Devops related issues (stagings servers, ...) priority 3 - nice to have
Projects
None yet
Development

No branches or pull requests

4 participants