Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep both axes fixed while playing an animation #2701

Closed
Tracked by #2804
sophiamersmann opened this issue Oct 5, 2023 · 5 comments
Closed
Tracked by #2804

Keep both axes fixed while playing an animation #2701

sophiamersmann opened this issue Oct 5, 2023 · 5 comments

Comments

@sophiamersmann
Copy link
Member

sophiamersmann commented Oct 5, 2023

Description

  • When playing an animation, only the current snapshot is taken into account
  • As a result, the x-axis and y-axis change during the animation (see video below)
  • This makes it difficult to understand the evolution/history of an indicator

Expected behaviour

Keep the x- and y-axis fixed while the animation is playing.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to any chart, e.g. https://ourworldindata.org/grapher/life-expectancy?tab=chart&time=earliest..2021
  2. Click on the play button
  3. Note that both axis ranges change while the animation is playing

Screenshots

Screen.Recording.2023-10-05.at.09.27.23.mov

This:

Screen.Recording.2023-08-28.at.15.37.03.mov

Not this

Screen.Recording.2023-08-28.at.15.37.32.mov
@sophiamersmann sophiamersmann changed the title Keep y-axis fixed while playing an animation Keep axes fixed while playing an animation Oct 19, 2023
@sophiamersmann sophiamersmann changed the title Keep axes fixed while playing an animation Keep both axes fixed while playing an animation Oct 19, 2023
@sophiamersmann
Copy link
Member Author

sophiamersmann commented Oct 19, 2023

Hey @ikesau, I'm inclined to bump the priority of this issue up. It's brought to our attention regularly and it's something we really want to do since the timeline animation as it is today often does not show the evolution of a variable very clearly.

@danyx23
Copy link
Contributor

danyx23 commented Oct 26, 2023

@sophiamersmann @marcelgerber could we enumerate the cases where just calculating the X and Y domain from the input table would not work and try to carve those out especially? I think the scatter plot animation change is quite nice but it depends on having a solution for fixing both axis while we play.

If you think this isn't a relatively easy thing to do then it's not worth it, just trying to see if we can get to a place that is clearly better than what we have today without too much effort.

@sophiamersmann
Copy link
Member Author

sophiamersmann commented Oct 26, 2023

I think the easiest thing to do might be to implement it (should be quick to do if we're using the input table), put it on staging, and we all look at some examples?

@marcelgerber
Copy link
Member

I think the easiest thing to do might be to implement it (should be quick to do if we're using the input table), put it on staging, and we all look at some examples?

Agreed!

Copy link

github-actions bot commented Jan 1, 2025

This issue has had no activity within 10 months. It is considered stale and will be closed in 7 days unless it is worked on or tagged as pinned.

@github-actions github-actions bot added the stale label Jan 1, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants