From b3a5c97693137fd0c652be2292781d00ae45c410 Mon Sep 17 00:00:00 2001 From: Marcel Gerber Date: Mon, 11 Mar 2024 18:45:13 +0100 Subject: [PATCH 1/2] fix(homepage): url-encode tag name for icon --- site/gdocs/components/ExplorerTiles.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/site/gdocs/components/ExplorerTiles.tsx b/site/gdocs/components/ExplorerTiles.tsx index 9e5667c71c2..543b2b3f0a8 100644 --- a/site/gdocs/components/ExplorerTiles.tsx +++ b/site/gdocs/components/ExplorerTiles.tsx @@ -18,7 +18,9 @@ function ExplorerTile({ url }: { url: string }) { ) : null From 9b265644e729ab6c4087540d87b2f247f017c948 Mon Sep 17 00:00:00 2001 From: Marcel Gerber Date: Mon, 11 Mar 2024 18:45:30 +0100 Subject: [PATCH 2/2] enhance(homepage): use lazy-loading and provide alt text --- site/gdocs/components/ExplorerTiles.tsx | 2 ++ site/gdocs/components/HomepageIntro.tsx | 1 + 2 files changed, 3 insertions(+) diff --git a/site/gdocs/components/ExplorerTiles.tsx b/site/gdocs/components/ExplorerTiles.tsx index 543b2b3f0a8..2a388b07077 100644 --- a/site/gdocs/components/ExplorerTiles.tsx +++ b/site/gdocs/components/ExplorerTiles.tsx @@ -22,6 +22,8 @@ function ExplorerTile({ url }: { url: string }) { linkedChart.tags[0].name )}.svg`} className="explorer-tile__icon" + alt={`Icon for topic ${linkedChart.tags[0].name}`} + loading="lazy" /> ) : null diff --git a/site/gdocs/components/HomepageIntro.tsx b/site/gdocs/components/HomepageIntro.tsx index b5c4cf7b87d..3c905c3899e 100644 --- a/site/gdocs/components/HomepageIntro.tsx +++ b/site/gdocs/components/HomepageIntro.tsx @@ -165,6 +165,7 @@ export function HomepageIntro({ className, featuredWork }: HomepageIntroProps) { alt="Logos of the publications that have used our content. From left to right: Science, Nature, PNAS, BBC, Financial Times, The New York Times, The Guardian, The Atlantic, and The Washington Post" width={230} height={75} + loading="lazy" />