diff --git a/packages/@ourworldindata/grapher/src/controls/ActionButtons.tsx b/packages/@ourworldindata/grapher/src/controls/ActionButtons.tsx
index 25d3e4ea286..fbf29a2d8fc 100644
--- a/packages/@ourworldindata/grapher/src/controls/ActionButtons.tsx
+++ b/packages/@ourworldindata/grapher/src/controls/ActionButtons.tsx
@@ -245,7 +245,6 @@ export class ActionButtons extends React.Component<{
onMouseDown?: React.MouseEventHandler
showLabel?: boolean
- title?: string
isActive?: boolean
style?: React.CSSProperties
}): JSX.Element {
@@ -336,7 +333,6 @@ export function ActionButton(props: {
(props.isActive ? "active" : "") +
(props.showLabel ? "" : " icon-only")
}
- title={props.title ?? props.label}
data-track-note={props.dataTrackNote}
onClick={(e: React.MouseEvent): void => {
if (props.onClick) props.onClick(e)
diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
index a4118f7a720..900ad7d8ab4 100644
--- a/packages/@ourworldindata/grapher/src/core/Grapher.tsx
+++ b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -2689,7 +2689,7 @@ export class Grapher
}
@computed get isOnCanonicalUrl(): boolean {
- if (!this.canonicalUrl || this.isInIFrame) return false
+ if (!this.canonicalUrl) return false
return (
getWindowUrl().pathname === Url.fromURL(this.canonicalUrl).pathname
)
diff --git a/packages/@ourworldindata/grapher/src/dataTable/DataTable.jsdom.test.tsx b/packages/@ourworldindata/grapher/src/dataTable/DataTable.jsdom.test.tsx
index d179a0e4377..a139e0849c1 100755
--- a/packages/@ourworldindata/grapher/src/dataTable/DataTable.jsdom.test.tsx
+++ b/packages/@ourworldindata/grapher/src/dataTable/DataTable.jsdom.test.tsx
@@ -133,7 +133,7 @@ describe("when the table has aggregates", () => {
view = Enzyme.mount()
})
- it("renders a title row for countries and regions", () => {
+ it("renders a separating title row for aggregates", () => {
const titleRows = view.find("tbody .title")
expect(titleRows).toHaveLength(1)
expect(titleRows.at(0).text()).toBe("Other")
diff --git a/packages/@ourworldindata/grapher/src/dataTable/DataTable.tsx b/packages/@ourworldindata/grapher/src/dataTable/DataTable.tsx
index 8f55934ae5a..7a94a2c2167 100644
--- a/packages/@ourworldindata/grapher/src/dataTable/DataTable.tsx
+++ b/packages/@ourworldindata/grapher/src/dataTable/DataTable.tsx
@@ -141,12 +141,7 @@ export class DataTable extends React.Component<{
}
@computed get manager(): DataTableManager {
- return (
- this.props.manager ?? {
- table: BlankOwidTable(),
- entityType: DEFAULT_GRAPHER_ENTITY_TYPE,
- }
- )
+ return this.props.manager ?? { table: BlankOwidTable() }
}
@computed private get entityType(): string {
diff --git a/packages/@ourworldindata/grapher/src/header/Header.tsx b/packages/@ourworldindata/grapher/src/header/Header.tsx
index 302f76fd3a2..b66bb699e1b 100644
--- a/packages/@ourworldindata/grapher/src/header/Header.tsx
+++ b/packages/@ourworldindata/grapher/src/header/Header.tsx
@@ -131,7 +131,7 @@ export class Header<
const { manager } = this
// avoid linking to a grapher/data page when we're already on it
- if (manager.isOnCanonicalUrl) {
+ if (manager.isOnCanonicalUrl && !this.manager.isInIFrame) {
return (
{this.title.renderHTML()}
)
@@ -144,6 +144,7 @@ export class Header<
href={manager.canonicalUrl}
target="_blank"
rel="noopener noreferrer"
+ data-track-note="chart_click_title"
>
{this.title.renderHTML()}
@@ -159,6 +160,7 @@ export class Header<
href={manager.canonicalUrl}
target="_blank"
rel="noopener noreferrer"
+ data-track-note="chart_click_title"
>
{this.title.renderHTML()}
diff --git a/packages/@ourworldindata/grapher/src/header/HeaderManager.ts b/packages/@ourworldindata/grapher/src/header/HeaderManager.ts
index 8ad3bfcf49f..d68d3428bb4 100644
--- a/packages/@ourworldindata/grapher/src/header/HeaderManager.ts
+++ b/packages/@ourworldindata/grapher/src/header/HeaderManager.ts
@@ -17,4 +17,5 @@ export interface HeaderManager {
framePaddingHorizontal?: number
framePaddingVertical?: number
isOnCanonicalUrl?: boolean
+ isInIFrame?: boolean
}
diff --git a/packages/@ourworldindata/grapher/src/modal/DownloadModal.scss b/packages/@ourworldindata/grapher/src/modal/DownloadModal.scss
index 09dc903bd66..8346a7dbabe 100644
--- a/packages/@ourworldindata/grapher/src/modal/DownloadModal.scss
+++ b/packages/@ourworldindata/grapher/src/modal/DownloadModal.scss
@@ -69,6 +69,7 @@
color: $light-text;
font-size: 0.875em;
font-weight: 500;
+ line-height: 1.15;
}
}
@@ -110,7 +111,7 @@
opacity: 0.9;
color: $light-text;
font-weight: 500;
- line-height: 1.5;
+ line-height: 1.15;
letter-spacing: 0.14px;
}