From 52cd6687db79c73d2819d917a46079484ad650c1 Mon Sep 17 00:00:00 2001 From: Matthieu Date: Fri, 1 Dec 2023 16:26:08 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20(donate)=20add=20setting=20for?= =?UTF-8?q?=20flag=20to=20fix=20eslint=20warning?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- site/SiteNavigation.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/site/SiteNavigation.tsx b/site/SiteNavigation.tsx index 7328feaebfc..0f799f90694 100644 --- a/site/SiteNavigation.tsx +++ b/site/SiteNavigation.tsx @@ -31,6 +31,10 @@ export enum Menu { Search = "search", } +// Note: tranforming the flag from an env string to a boolean in +// clientSettings.ts is convoluted due to the two-pass SSR/Vite build process. +const HAS_DONATION_FLAG = false + export const SiteNavigation = ({ baseUrl, hideDonationFlag, @@ -220,15 +224,11 @@ export const SiteNavigation = ({ - {/* - Uncomment below to show the "Giving season" flag on pages where it should not be hidden. - We probably want to make a setting for this if it becomes a yearly occurrence. - */} - {/* {!hideDonationFlag && ( + {HAS_DONATION_FLAG && !hideDonationFlag && ( Giving season - )} */} + )}