Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart-diff: some diffs are hidden sometimes for branches pre chart model migration #3246

Closed
lucasrodes opened this issue Sep 5, 2024 · 2 comments
Labels
bug Something isn't working wizard Issues related to wizard tool

Comments

@lucasrodes
Copy link
Member

lucasrodes commented Sep 5, 2024

One-liner

After the recent migration to the chart_config table (see owid/owid-grapher#3767), some chart diffs are hidden in the app.

Context & details

Mojmir (from Slack):

It’s not easily fixable by code, but it’ll work if you re-save those charts in admin. (This will change their updatedAt timestamp and everything’s gonna work like before)

@lucasrodes lucasrodes added wizard Issues related to wizard tool bug Something isn't working needs triage labels Sep 5, 2024
@Marigold
Copy link
Collaborator

Marigold commented Sep 6, 2024

For the context - I only saw this issue on one staging server, not sure if any other were affected. The problem was that function _get_staging_creation_time didn't return the correct time of server creation.

I haven't thoroughly investigated why. We use the creation time of charts table (with show table status like 'charts'), but it got changed on that server and charts that were updated before weren't showing up.

It's a one-time thing, it should be good after re-saving charts or with new staging servers.

@larsyencken larsyencken changed the title chart-diff: some diffs are hidden sometimes chart-diff: some diffs are hidden sometimes for branches pre chart model migration Sep 12, 2024
@larsyencken larsyencken added wontfix This will not be worked on and removed needs triage labels Sep 12, 2024
@stale stale bot removed the wontfix This will not be worked on label Sep 12, 2024
@larsyencken
Copy link
Collaborator

From triage discussion, we think that you were the unlucky last person to experience it, and that it won't come up again for new work.

@larsyencken larsyencken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wizard Issues related to wizard tool
Projects
None yet
Development

No branches or pull requests

3 participants