Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ explorers: markdown → html #1643

Closed
42 tasks done
lucasrodes opened this issue Sep 21, 2023 · 4 comments
Closed
42 tasks done

⚠️ explorers: markdown → html #1643

lucasrodes opened this issue Sep 21, 2023 · 4 comments

Comments

@lucasrodes
Copy link
Member

lucasrodes commented Sep 21, 2023

In #1422, we only looked at descriptions using HTML in ETL. However, there are still some charts and explorers using HTML: Those from manual configs in explorers, datasets that were manually imported in the past, and datasets imported via importers.

This issue tries to address this for Explorers. I've included the list of explorers below; could you check these as those are fixed?

Guidelines

There are different types of explorers, and reviewing these might be different.

  • Indicator-based: We should go back to the snapshot in ETL, which is the source for the indicator. Example: animal-welfare
  • Chart-based: We should investigate where the dataset powering the used charts comes from. If from ETL, check ETL. Other sources could be importers or manual imports. Example: democracy
  • Manual config: The explorer configuration is written in the admin explorer configm. We need to edit this. Example: coronavirus-data-explorer
  • Templating: The explorer configuration was generated automatically using owid-content. Example: population-and-demography

List of explorers to review

(only public ones)

@lucasrodes
Copy link
Member Author

some work for explorers based on templating done here: : owid/owid-content#31

@lucasrodes
Copy link
Member Author

@paarriagadap Hey Pablo, I've already implemented some changes in owid/owid-content#31. Some of it affects your work; it would be helpful if you could briefly review it. Thanks!

@pabloarosado
Copy link
Contributor

@lucasrodes, after merging owid/owid-content#33 all explorers in the list should be cleared of HTML tags. Shall we close the issue?

@lucasrodes
Copy link
Member Author

Thanks for your work, @pabloarosado @paarriagadap

Closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants