From 153a4556381278af7958e4a08c1de5ef0e9c67ce Mon Sep 17 00:00:00 2001 From: Danyal Faheem Date: Wed, 6 Dec 2023 19:55:37 +0500 Subject: [PATCH 1/2] feat: allow post npm build patch in dockerfile --- tutormfe/templates/mfe/build/mfe/Dockerfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tutormfe/templates/mfe/build/mfe/Dockerfile b/tutormfe/templates/mfe/build/mfe/Dockerfile index f0d74c26..2a55fb0a 100644 --- a/tutormfe/templates/mfe/build/mfe/Dockerfile +++ b/tutormfe/templates/mfe/build/mfe/Dockerfile @@ -93,6 +93,8 @@ CMD ["/bin/bash", "-c", "npm run start --- --config ./webpack.dev-tutor.config.j FROM {{ app_name }}-common AS {{ app_name }}-prod ENV NODE_ENV=production RUN npm run build +{{ patch("mfe-dockerfile-post-npm-build") }} +{{ patch("mfe-dockerfile-post-npm-build-{}".format(app_name)) }} {% endfor %} ####### final production image with all static assets From ccecfaaa41f20ed23275fa74a6fd0582ea74265a Mon Sep 17 00:00:00 2001 From: Danyal Faheem Date: Fri, 8 Dec 2023 11:42:07 +0500 Subject: [PATCH 2/2] docs: add changelog entry --- .../20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md diff --git a/changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md b/changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md new file mode 100644 index 00000000..8d5bf3cb --- /dev/null +++ b/changelog.d/20231208_112435_danyal.faheem_mfe_post_npm_build_patch.md @@ -0,0 +1 @@ +- [Feature] Added patch to allow changes to Dockerfile after the npm build has completed. (by @Danyal-Faheem) \ No newline at end of file