From 5fd24b154be5214666f3d47112057873165d19ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Jutteau?= Date: Thu, 18 Jan 2024 14:56:29 +0100 Subject: [PATCH] github_repos: fix ignored query parameters of reqwest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Jutteau --- src/github_repos.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/github_repos.rs b/src/github_repos.rs index 1aa4a27..fe8370d 100644 --- a/src/github_repos.rs +++ b/src/github_repos.rs @@ -223,22 +223,25 @@ impl GithubRepo { async fn get_releases(&self) -> Option> { debug!("getting all releases for github repo {}", self.full_name); - let Ok(agent) = request_agent() else { - return None; - }; - let url = format!("https://api.github.com/repos/{}/releases", self.full_name); let mut page = 1; let mut release_list: Vec = Vec::new(); let default_items_per_page = DEFAULT_ITEM_PER_PAGE.to_string(); loop { + let Ok(agent) = request_agent() else { + return None; + }; let page_str = page.to_string(); let mut params = HashMap::new(); params.insert("type", "public"); params.insert("per_page", &default_items_per_page); params.insert("page", page_str.as_str()); + let url = format!("https://api.github.com/repos/{}/releases", self.full_name); + let Ok(url) = reqwest::Url::parse_with_params(&url, ¶ms) else { + break; + }; let resp = match agent - .get(&url) + .get(url.as_str()) .header("Authorization", &format!("token {}", self.github_token)) .header("User-Agent", "richard/0.0.0") .header("Accept", "application/vnd.github+json")