Fix warnings in doc comments #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonHermann
commented
Nov 12, 2021
Escape square brackets comments containing "[INFO]", "[WARNING]", "[ERROR]" Suppress automatic link markup warning
marcospb19
reviewed
Nov 13, 2021
marcospb19
reviewed
Nov 13, 2021
|
Regarding the URL markup not getting correctly parsed by The clap issue I mentioned earlier was closed because there already is clap-rs/clap#2389 addressing a superset of this automatic link markup (i.e. parsing markdown/markup in general). If this is fixed someday, we could add the markup in src/opts.rs again (this has suuper low importance :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic link markup to urls
Escape square brackets comments containing "[INFO]", "[WARNING]", "[ERROR]"