-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help adding async-listener to citgm #111
Comments
Whoops! I had my work laptop configured to push tags by default, but when I lost that job, I forgot to copy the requisite configuration over to my personal machine. Tags pushed and configuration fixed.
$ npm owner add watson async-listener
+ watson (async-listener) Also, you've been invited to join this repo as a maintainer. Let me know if you need anything else! |
Thanks 😃 Looking forward to be able to help out |
@Qard ^^ I just realized I should have checked in with you before Just Doing It, but it seems like a good idea to have someone actively working on APM with access to async-listener, no? |
No worries, I definitely agree there! |
Hi @othiym23
Async-listener is depended upon by a lot of people in the community either directly via modules like continuation-local-storage, or indirectly by APM vendors.
Since async-listener heavily monkey patches node core, chances of it breaking due to simple internal refactors of node core is high (e.g. #109).
I'd therefore like to have async-listener added to citgm so these issues are caught as early as possible in the future.
To be considered part of citgm, the module have to adhere to the following requirements:
npm install && npm test
using the tarball downloaded from the Github tag mentioned aboveAt the moment this is not possible because the releases on GitHub isn't up to date (
git push --tags
). Also I wouldn't want to add this burden on you alone, so if you want, I'd like to help out with the maintenance and also adding my name to the list of contacts in citgm for async-listener.The text was updated successfully, but these errors were encountered: