Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the gem sass-rails to version 6 #355

Open
KennaW opened this issue Jan 3, 2020 · 1 comment
Open

update the gem sass-rails to version 6 #355

KennaW opened this issue Jan 3, 2020 · 1 comment

Comments

@KennaW
Copy link

KennaW commented Jan 3, 2020

Sass-rails 4 is running EOL ruby sass

https://github.com/osulp/Room-Reservation/blob/master/Gemfile#L22

Sass-rails 6 update should take care of it.

if the sass-rails update breaks the css, just leave it on a branch and I (Kenna :) ) will fix the css there

@luisgreg99
Copy link
Contributor

luisgreg99 commented Jan 3, 2020

I tried to upgrade to gem 'sass-rails', '~>6.0', and I found that it also requires at least sprockets 3.7.2. I pushed the update in this branch upgrade/sass-rails-from-2-to-6 for testing

It looks like sass-rails should be automatically updated to 6 with #354, which was recently posted by GitHub dependabot. This updates sass-rails to 6 and sprockets to 4, but it also does a rails upgrade from 4.2.11 to 5.2.4.1. I think #354 should resolve this update, but it needs additional changes since rails 5 requires these updates to the codebase to bump to rails 5: https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-2-to-rails-5-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants