Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated pydantic.GenericModel #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove use of deprecated pydantic.GenericModel #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/common/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
import orjson
from fastapi import Request
from fastapi.responses import RedirectResponse
from pydantic.generics import GenericModel
from pydantic import BaseModel

from app.common import json
from app.common.errors import ServiceError

T = TypeVar("T")


class Success(GenericModel, Generic[T]):
class Success(BaseModel, Generic[T]):
status: Literal["success"]
data: T

Expand All @@ -31,7 +31,7 @@ def success(
return json.ORJSONResponse(data, status_code, headers)


class ErrorResponse(GenericModel, Generic[T]):
class ErrorResponse(BaseModel, Generic[T]):
status: Literal["error"]
error: T
message: str
Expand Down