-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using JSON files #9
Comments
@acbuynak Tagging you to get your thoughts on the actionable and to make sure I haven't omitted anything from our conversations. |
I like this approach. Some quick thoughts below..
I'd suggest creation of a workspace-like folder in the package where all files changed during the process would be stored. (except things like Dream3D files, which are inherently modified when run). Otherwise, sounds great! Any specific line items you would want me to tackle? Ideas on how to divvy up? |
Lets keep talking about the directory; I think that's a good idea but I'm not sure how exactly we'd like to do it. I'll take care of everything else in a new branch. |
New branch is created. We should test this on the robot (or on your set up) to verify that I have not messed anything up with rospy. |
Sweet. I'll test tonight (less camera control) on my system. |
Summary
This comment summarizes several conversations about how to use JSON data structures to pass information to the
photogrammetry_capture_runner.py
andread_posn.py
.Whatever program runs the robot to get the orthogonal images to estimate the size, position, and orientation should output a JSON file with that information. This file should also be where the user inputs their desired path plan and any parameters.
Because both of the aforementioned files require the same information (about both part and plan) this would ensure that this information is consistent between the two.
For testing it'll be easiest to manually create or edit these JSON files so the
photogrammetry_capture_runner.py
andread_posn.py
scripts will take a desired JSON as input and eventually, we will develop a parameter server so the user may specify a specific JSON in ROS.In actual deployment, however, the users should not need to interact with the JSON file so the system will need to save and load this information between the programs.
Actionable Items
photogrammetry_capture_runner.py
to take a user inputread_posn.py
to take a user inputpath_plans.py
)The text was updated successfully, but these errors were encountered: