New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The parseConfigWithIncludes() should be split up into smaller methods #31

Open

wdoekes opened this issue May 12, 2017 · 0 comments

Labels

Member

wdoekes commented May 12, 2017

See:

gocollect/gocollect.go

Line 106 in 8862313

func parseConfigWithIncludes(config *configMap, filename string,

This function is too large. It should be split up into a couple of methods.
It should be moved into a separate file.
It should get tests.

wdoekes added the SpringCleaning label

wdoekes changed the title ~~The~~ The parseConfigWithIncludes() should be split up into smaller methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment