Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency of tag rebuilds for osrf/ros2? #563

Closed
aprotyas opened this issue Aug 24, 2021 · 14 comments
Closed

Frequency of tag rebuilds for osrf/ros2? #563

aprotyas opened this issue Aug 24, 2021 · 14 comments

Comments

@aprotyas
Copy link

Hi, I noticed that the devel tag on Dockerhub has not been pushed in about a month now. I was just curious to know if there's a schedule to push?

@sloretz
Copy link
Contributor

sloretz commented Sep 3, 2021

Thanks for the report! This is a duplicate of this issue: #112

In short they get updated when the Ubuntu base image updates. There's no button we can click on dockerhub to clear the cache and rebuild them, and it's not as simple as adding a line in the Dockerfile to break the cache because the change needs to be accepted by the upstream Docker Library maintainers.

@sloretz sloretz closed this as completed Sep 3, 2021
@ruffsl ruffsl reopened this Sep 7, 2021
@ruffsl
Copy link
Member

ruffsl commented Sep 7, 2021

The devel tag is an image under the osrf org, not the upstream official library. I suspect docker hubs change in making auto builds a subscription feature has interrupted our nightly build triggers. I was told that osrf had applied for open source plan on docker hub to retain this functionality, but perhaps this isn't yet in effect. I'll look into it this afternoon

@ruffsl
Copy link
Member

ruffsl commented Sep 7, 2021

I was told that osrf had applied for open source plan on docker hub to retain this functionality, but perhaps this isn't yet in effect. I'll look into it this afternoon

Yep, looks like the osrf org no longer has access to auto rebuilds, thus the current stale images.

image

CC @nuclearsandwich @tfoote

@tfoote
Copy link
Contributor

tfoote commented Sep 20, 2021

We still haven't heard back about our application to the Docker Open Source Program. They promised an answer to our application within 2 weeks on July 16th but I haven't heard anything back. I just pinged them back.

@tfoote
Copy link
Contributor

tfoote commented Sep 27, 2021

There was a promise of a few days response to my last email. However I still haven't heard anything. And now that it's been over a month I think that we should start thinking about other options.

@aprotyas
Copy link
Author

Any updates? These images were very useful for me!

@tfoote
Copy link
Contributor

tfoote commented Oct 30, 2021

After one month more and no word back from Docker Open Source Project I think we should not expect any more action on that front. I think the latest thing that I read was that there were 40 projects approved which means that they've only approved a very small set of open source projects and they all appear to be very closely related to docker itself.

@ruffsl
Copy link
Member

ruffsl commented Nov 2, 2021

Just to add to that update, we are now planning to migrate to GitHub actions to host the docker image build pipeline, like we did over on the Nav2 repo, but instead keeping Docker Hub as the image registry.

@tfoote
Copy link
Contributor

tfoote commented Nov 15, 2021

Hey great news. I was just informed that OSRF has been accepted into the Docker Open Source Program.

"We have allow-listed your namespace "osrf" and this should come into effect in the next week or so. With this allowed-listing, the Docker data pull rate policies that went into effect last November, will not apply to the users pulling images from your namespace. "

@ruffsl
Copy link
Member

ruffsl commented Nov 17, 2021

@tfoote , great to hear that OSRF has been accepted into the Docker Open Source Program! However, I'm afraid this allowed-listing to exempt us from the Docker data pull rate policies did not re-enable our automated build service on DockerHub, as the admin panel still looks the same as from #563 (comment) . From my prior email offline, did you have the chance to create and provision a DockerHub machine account, for our GitHub actions to use to push built images?

@gavanderhoorn
Copy link

Has auto-building of the images been sorted in the meantime?

@tfoote
Copy link
Contributor

tfoote commented Jan 21, 2022

I got the tokens sorted out earlier this month. We're hoping to deploy this action shortly: https://github.com/marketplace/actions/dockerhub-build-and-push

@ruffsl
Copy link
Member

ruffsl commented Feb 16, 2022

Closing with #588 (comment)

@ruffsl ruffsl closed this as completed Feb 16, 2022
@tfoote
Copy link
Contributor

tfoote commented Mar 3, 2022

Thanks for pushing this all through @ruffsl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants