A possible bug in Osmand

[laramaceo]

Hello!

I am Osmand user and Open street map contributor. I am not completely sure, but I think I have found a bug in Osmand. I have placed an artwork as a point of interest and added to the label the name of the artist and the architect of the artwork. I see that above the artist's name the title "Artist" appears, but the title "architect" does not appear above the name of the work's architect. If this is a bug in the application, could you fix it? I hope I am understood, this is a Spanish language translation and I hope the fix is available for the Spanish language as well. I attach two illustrative images. Thank you very much.

[osmandlover]

Hi laramaceo, I took a look at your issue and I can explain why this is happening.

On line 360 of the OsmAnd/src/net/osmand/plus/mapcontextmenu/builders/AmenityUIHelper.java file, OsmAnd blanks out the title (which it calls the "textPrefix") of any text label that has an icon, except for the description.

	if (!isDescription && icon == null) {
		icon = getRowIcon(view.getContext(), pType.getIconKeyName());
		if (isText && icon != null) {
			textPrefix = "";
		}
	}

You will notice in your screenshot you posted that "Architect" has a person icon, but "Artist name" doesn't, it just has a generic (i) icon.

I think the idea here is that items that have an icon are sufficient to explain what they are. If you look at the calendar one for example, that should tell you that it is a date, and so perhaps the tag "Start date" isn't needed. The ones that are numbers (e.g. height, width) have both labels and icons, and the ones that are enums (a few possible values, e.g. Artwork type, material) have a label as part of the message.

The easy way to fix this is to simply remove the code I quoted completely, which makes every line item have a label like this:

However I have made a dirtier but safer fix that just adds the title for the Architect field specifically. This has a side effect of changing the icon slightly to a specific one for architect, I have no idea why, but I think the specific architect icon is better. The solution looks like this:

I'll submit a pull request for this and hopefully the OsmAnd maintainers will agree and merge it.

[osmandlover]

Pull request submitted here: #19129

[laramaceo]

Thank you for the answer and the solution, I hope your change will be accepted.

Seagull
The image of the sculpture.