Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-caps Georgian labels are invisible #837

Closed
1ec5 opened this issue Mar 26, 2023 · 8 comments · Fixed by #838
Closed

All-caps Georgian labels are invisible #837

1ec5 opened this issue Mar 26, 2023 · 8 comments · Fixed by #838
Labels
bug Something isn't working internationalization

Comments

@1ec5
Copy link
Member

1ec5 commented Mar 26, 2023

When the preferred language is set to Georgian, any layer that contains all-capital letters appears blank, namely, state/provincial labels and boundary edge labels.

English Georgian
English versus Georgian

In practice, the Georgian alphabet is unicameral, but capital letters are used for decorative purposes, such as the reason why we’re uppercasing these labels.

@1ec5 1ec5 added bug Something isn't working internationalization labels Mar 26, 2023
@1ec5
Copy link
Member Author

1ec5 commented Mar 26, 2023

The capital letters are located in the Georgian Extended block, 0x1C90–0x1CBF. The downloaded Noto Sans Georgian Regular font does contain glyphs for each of these codepoints, but the range 7312–7359 needs to be associated with Georgian so that the generated Americana-Regular font will contain these codepoints:

"georgian": [
[4256, 4351],
[11520, 11567]
],

I’ve tried adding this range and doing a clean rebuild, but the uppercase letters still aren’t showing up, even though Americana-Regular.ttf does contain these glyphs.

@1ec5
Copy link
Member Author

1ec5 commented Mar 26, 2023

This issue doesn’t reproduce in 22615be, which was right before #801 and used the OpenHistorical fontstack:

OpenHistorical

@ZeLonewolf
Copy link
Member

Initial debugging shows that the issue manifests when text-transform: uppercase is used.

image

@1ec5
Copy link
Member Author

1ec5 commented Mar 26, 2023

Yes, because the font PBFs don’t contain glyphs for the uppercase letters. If you force the text-field to contain uppercase letters, they don’t show up.

@ZeLonewolf
Copy link
Member

Noto Sans Georgian does seem to have the characters:

image

I'm pulling in the ranges:

[4256, 4351],
[11520, 11567]

Which should correspond to the regular and supplemental Georgian language blocks

@ZeLonewolf
Copy link
Member

FontDrop reports Georgian language support and draws Georgian capital letter characters
image

@ZeLonewolf
Copy link
Member

Oh I just saw your note about the missing range.

@1ec5
Copy link
Member Author

1ec5 commented Mar 26, 2023

Doh, adding the range didn’t work for me locally because the style was pointed to the production glyphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants