Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ellipse shield-draw function vertical text alignment #716

Closed
michaelblyons opened this issue Jan 19, 2023 · 2 comments
Closed

Ellipse shield-draw function vertical text alignment #716

michaelblyons opened this issue Jan 19, 2023 · 2 comments
Labels
bug Something isn't working shields

Comments

@michaelblyons
Copy link
Contributor

The screenshots for #706 do not appear to vertically center the text. Ellipses are vertically symmetrical, so the padding should be even top and bottom. (Unlike, say, the triangle shields 😬 )
@claysmalley claysmalley added bug Something isn't working shields labels Jan 19, 2023
@claysmalley
Copy link
Member

This seems to be the case for quite a lot of shields, not just ellipses. Something weird is going on with vertical alignment in shield_text.js.

@claysmalley
Copy link
Member

Closing as fixed by #965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working shields
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claysmalley @michaelblyons