Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend does not distinguish between notext routes with different shields in the same network #1184

Open
quincylvania opened this issue Jan 2, 2025 · 5 comments
Labels

Comments

@quincylvania
Copy link
Contributor

I would expect to see the specific route name of each shield listed out when they have unique images and no text. These are all overrideByRef or overrideByName from what I can tell. It might be good to retain the parent network name as a subheading and list the individual routes under that.


Screenshot 2025-01-02 at 1 54 32 PM
Screenshot 2025-01-02 at 2 02 02 PM
Screenshot 2025-01-02 at 2 02 33 PM

@1ec5
Copy link
Member

1ec5 commented Jan 3, 2025

This happens whenever the routes all share a common network=* value. The legend entries are tied to Wikidata items that describe these networks. In order to distinguish between the routes within a network, we’d need access to the Wikidata QID of each individual route, but the tiles don’t expose this information yet. Ideally, the OpenMapTiles schema would include a route_2_wikidata field or somesuch, building on openmaptiles/openmaptiles#1620.

Even so, some networks have routes that don’t really need to be called out separately, especially color-coded networks such as the Allegheny County Belt Routes or the Branson color routes.

@ZeLonewolf
Copy link
Member

The Nova Scotia example is very wide at 4 shields, should this wrap at some point if a lot of routes are in view for these kinds of networks?

@1ec5
Copy link
Member

1ec5 commented Jan 3, 2025

Yes, but as a separate issue, since that would be purely on our end as a styling problem. I recall having a solution at some point, but I forget why I didn’t commit it.

@quincylvania
Copy link
Contributor Author

Even so, some networks have routes that don’t really need to be called out separately, especially color-coded networks such as the Allegheny County Belt Routes or the Branson color routes.

My counterpoint would be colorblind accessibility. Sure, there are cases where two colors may be indistinguishable. But often the colors are distinct yet it's hard to tell what the color names are supposed to be.


Screenshot 2025-01-05 at 4 04 31 PM

@1ec5
Copy link
Member

1ec5 commented Jan 6, 2025

Ack, you’re right. So, similar to the networks that use cryptic symbols in a common motif, we’d need to call out each one individually but still group them so we can call them by the name of the overall network. This is important because the legend only shows the shields that happen to be visible currently, with the idea that the user can detect the pattern and extrapolate to other shields they encounter elsewhere.

It might become less necessary to describe each individual route shield in detail once we add interactivity to the map. A popup anchored on the route shield in situ would be more effective than a replica out of context in the legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants