From f419d65deec0e00b6c76502a49ad9cc1841a641b Mon Sep 17 00:00:00 2001 From: Brian Sperlongano Date: Mon, 31 Jul 2023 19:24:28 -0400 Subject: [PATCH 1/3] Add version note --- .github/workflows/test-build-ubuntu.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test-build-ubuntu.yml b/.github/workflows/test-build-ubuntu.yml index e52a87a94..1a3f03b37 100644 --- a/.github/workflows/test-build-ubuntu.yml +++ b/.github/workflows/test-build-ubuntu.yml @@ -10,6 +10,9 @@ jobs: steps: - name: Checkout 🛎️ uses: actions/checkout@v3 +# Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu. +# See PR #905 and #908 for more details. +# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.0. - name: Use Node.js 18.x uses: actions/setup-node@v3 with: From b15bc42a7938cdb0daf271dc430bbbd690894896 Mon Sep 17 00:00:00 2001 From: Brian Sperlongano Date: Mon, 31 Jul 2023 19:27:35 -0400 Subject: [PATCH 2/3] Force node v18.16.0 --- .github/workflows/test-build-ubuntu.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-build-ubuntu.yml b/.github/workflows/test-build-ubuntu.yml index 1a3f03b37..622494376 100644 --- a/.github/workflows/test-build-ubuntu.yml +++ b/.github/workflows/test-build-ubuntu.yml @@ -13,10 +13,10 @@ jobs: # Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu. # See PR #905 and #908 for more details. # If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.0. - - name: Use Node.js 18.x + - name: Use Node.js 18.16.0 uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 18.16.0 - name: Build Shield Library 🛡️ run: | cd shieldlib From 8d65b3d2343b0790ae69a6abdbce5d4aa12194d4 Mon Sep 17 00:00:00 2001 From: Brian Sperlongano Date: Mon, 31 Jul 2023 21:47:04 -0400 Subject: [PATCH 3/3] Push all runners to 18.16.1 --- .github/workflows/build-preview.yml | 4 ++-- .github/workflows/deploy.yml | 4 ++-- .github/workflows/test-build-mac.yml | 7 +++++-- .github/workflows/test-build-ubuntu.yml | 6 +++--- 4 files changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-preview.yml b/.github/workflows/build-preview.yml index f42569976..ae0bb9f69 100644 --- a/.github/workflows/build-preview.yml +++ b/.github/workflows/build-preview.yml @@ -19,10 +19,10 @@ jobs: steps: - name: Checkout 🛎️ uses: actions/checkout@v3 - - name: Use Node.js 18.x + - name: Use Node.js 18.16.1 uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 18.16.1 #18.17.0 is buggy - name: Save PR number env: PR_NUMBER: ${{ github.event.pull_request.number }} diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 442069519..13b362704 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -20,10 +20,10 @@ jobs: steps: - name: Checkout 🛎️ uses: actions/checkout@v3 - - name: Use Node.js 18.x + - name: Use Node.js 18.16.1 uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 18.16.1 #18.17.0 is buggy - name: Install and Build 🔧 run: | npm ci --include=dev diff --git a/.github/workflows/test-build-mac.yml b/.github/workflows/test-build-mac.yml index e25e06941..dbb8781e2 100644 --- a/.github/workflows/test-build-mac.yml +++ b/.github/workflows/test-build-mac.yml @@ -10,10 +10,13 @@ jobs: steps: - name: Checkout 🛎️ uses: actions/checkout@v3 - - name: Use Node.js 18.x +# Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu. +# See PR #905 and #908 for more details. +# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.0. + - name: Use Node.js 18.16.1 uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 18.16.1 - name: Build Shield Library 🛡️ run: | cd shieldlib diff --git a/.github/workflows/test-build-ubuntu.yml b/.github/workflows/test-build-ubuntu.yml index 622494376..c0515a215 100644 --- a/.github/workflows/test-build-ubuntu.yml +++ b/.github/workflows/test-build-ubuntu.yml @@ -12,11 +12,11 @@ jobs: uses: actions/checkout@v3 # Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu. # See PR #905 and #908 for more details. -# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.0. - - name: Use Node.js 18.16.0 +# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.1. + - name: Use Node.js 18.16.1 uses: actions/setup-node@v3 with: - node-version: 18.16.0 + node-version: 18.16.1 - name: Build Shield Library 🛡️ run: | cd shieldlib