Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functions moved to Hecke #2846

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Remove functions moved to Hecke #2846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
910918d
Remove functionality moved to Hecke
lgoettgens Sep 21, 2023
e3aef47
Bump Hecke
lgoettgens Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ AbstractAlgebra = "0.32.1"
AlgebraicSolving = "0.3.3"
DocStringExtensions = "0.8, 0.9"
GAP = "0.9.4"
Hecke = "0.22"
Hecke = "0.22.1"
JSON = "^0.20, ^0.21"
Nemo = "0.36"
Polymake = "0.11.1"
Expand Down
28 changes: 0 additions & 28 deletions src/Modules/UngradedModules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8260,34 +8260,6 @@ function getindex(a::Hecke.SRow, b::AbstractVector{Int})
return b
end

@doc raw"""
sparse_row(A::MatElem)

Convert `A` to a sparse row.
`nrows(A) == 1` must hold.
"""
function sparse_row(A::MatElem)
@assert nrows(A) == 1
if ncols(A) == 0
return sparse_row(base_ring(A))
end
return Hecke.sparse_matrix(A)[1]
end

@doc raw"""
dense_row(r::Hecke.SRow, n::Int)

Convert `r[1:n]` to a dense row, that is an AbstractAlgebra matrix.
"""
function dense_row(r::Hecke.SRow, n::Int)
R = base_ring(r)
A = zero_matrix(R, 1, n)
for i in intersect(r.pos, 1:n)
A[1,i] = r[i]
end
return A
end

function default_ordering(F::FreeMod)
if iszero(F)
return default_ordering(base_ring(F))*ModuleOrdering(F, Orderings.ModOrdering(Vector{Int}(), :lex))
Expand Down
1 change: 0 additions & 1 deletion src/exports.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@ export demazure_character
export denest
export denominator
export denominators
export dense_row
benlorenz marked this conversation as resolved.
Show resolved Hide resolved
export depth
export derived_series, has_derived_series, set_derived_series
export derived_subgroup, has_derived_subgroup, set_derived_subgroup
Expand Down
Loading