From 910918db48f94c634f1e0eccc1ef3efea0bf629c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= Date: Thu, 21 Sep 2023 11:34:55 +0200 Subject: [PATCH 1/2] Remove functionality moved to Hecke --- src/Modules/UngradedModules.jl | 28 ---------------------------- src/exports.jl | 1 - 2 files changed, 29 deletions(-) diff --git a/src/Modules/UngradedModules.jl b/src/Modules/UngradedModules.jl index 8dfdf1af3455..03b90d5fe97c 100644 --- a/src/Modules/UngradedModules.jl +++ b/src/Modules/UngradedModules.jl @@ -8260,34 +8260,6 @@ function getindex(a::Hecke.SRow, b::AbstractVector{Int}) return b end -@doc raw""" - sparse_row(A::MatElem) - -Convert `A` to a sparse row. -`nrows(A) == 1` must hold. -""" -function sparse_row(A::MatElem) - @assert nrows(A) == 1 - if ncols(A) == 0 - return sparse_row(base_ring(A)) - end - return Hecke.sparse_matrix(A)[1] -end - -@doc raw""" - dense_row(r::Hecke.SRow, n::Int) - -Convert `r[1:n]` to a dense row, that is an AbstractAlgebra matrix. -""" -function dense_row(r::Hecke.SRow, n::Int) - R = base_ring(r) - A = zero_matrix(R, 1, n) - for i in intersect(r.pos, 1:n) - A[1,i] = r[i] - end - return A -end - function default_ordering(F::FreeMod) if iszero(F) return default_ordering(base_ring(F))*ModuleOrdering(F, Orderings.ModOrdering(Vector{Int}(), :lex)) diff --git a/src/exports.jl b/src/exports.jl index cb7bd8045768..21e18dac8e69 100644 --- a/src/exports.jl +++ b/src/exports.jl @@ -438,7 +438,6 @@ export demazure_character export denest export denominator export denominators -export dense_row export depth export derived_series, has_derived_series, set_derived_series export derived_subgroup, has_derived_subgroup, set_derived_subgroup From e3aef473185dac43cb835be013e0e1459a96d303 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= Date: Fri, 22 Sep 2023 22:55:01 +0200 Subject: [PATCH 2/2] Bump Hecke --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index ba78c3990fb9..dd53b7c1b42d 100644 --- a/Project.toml +++ b/Project.toml @@ -28,7 +28,7 @@ AbstractAlgebra = "0.32.1" AlgebraicSolving = "0.3.3" DocStringExtensions = "0.8, 0.9" GAP = "0.9.4" -Hecke = "0.22" +Hecke = "0.22.1" JSON = "^0.20, ^0.21" Nemo = "0.36" Polymake = "0.11.1"