Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support links in checkbox/boolean nodes #251

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Oct 24, 2024

Screen.Recording.2024-10-24.at.1.14.01.PM.mov

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Oct 24, 2024
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/linksInCheckboxes branch from c415911 to 0bf2e8f Compare October 24, 2024 11:51
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.03%. Comparing base (d719e15) to head (0bf2e8f).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...src/theme/default/components/ui/checkbox-label.tsx 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   51.95%   53.03%   +1.07%     
==========================================
  Files         103      104       +1     
  Lines         995     1022      +27     
  Branches      122      126       +4     
==========================================
+ Hits          517      542      +25     
- Misses        473      475       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit cc92b9c into main Oct 29, 2024
9 of 13 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/linksInCheckboxes branch October 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants