Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your latent mapper implementation is weird and possibly wrong #103

Open
johannwyh opened this issue Oct 21, 2022 · 1 comment
Open

Your latent mapper implementation is weird and possibly wrong #103

johannwyh opened this issue Oct 21, 2022 · 1 comment

Comments

@johannwyh
Copy link

As is stated in your paper and also a common practice, the latent mapper should learn a residual of the input code,

w_edit = w_input + M(w_input)

However, the residual step is not implemented in your latent_mapper and styleclip_mappper. And in your trainer, you choose to ignore the forward function of styleclip_mapper and directly access styleclip_mapper.mapper, which is quite weird.

@fmcarlucci
Copy link

Bumping this as I'm also interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants