-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for replace and replace_command #609
Comments
Agreed. We can also mention something like:
is the equivalent of: echo "<matched_part_of_the_changelog>" | typos --write-changes - Marked as good first issue, feel free to tackle this as well! |
Hi @orhun, for some reason, I don't have clarity on the issue, but I would love to tackle this. Could you please provide more details? Thanks! |
Hey @Muhammad-Owais-Warsi! You can start off by adding my comment above to the documentation for making things more clear. Also see the |
Yeah, at there and other relevant sections in the documentation. I would recommend trying out this feature for yourself to get a more clear idea about what to do here ;) |
Hey, I have made some little changes in the documentation addressing the issue mentioned above.
Let me know whether the changes are correct and if any other parts of the documentation need updates. Thanks! |
We can use "commit message" instead of "commit log". Other than that it seems fine, please send a PR - it is easier to discuss on the changes :) |
Sure @orhun |
In my PR #928 this test got failed. I tried to ran |
That's fine. Can also mention #609 (comment) in your PR? |
Is there an existing issue or pull request for this?
Feature description
changelog.postprocessors
andgit.commit_preprocessors
work on the entire changelog or git message respectively. The documentation does not clearly describe this. As a first time user, one might expect that either processor only affects the part of the input that actually matches thepattern
.For example, a postprocessor like the following would be expected to replace all occurrences of
<REPO>
withhttps://github.com/orhun/git-cliff
. It replaces the entire changelog instead.Desired solution
The documentation should be revised in all places to clearly state that
pattern
does not limit the scope of the replacement, but instead is only used to check if a given string is supposed to replaced entirely.Alternatives considered
None
Additional context
No response
The text was updated successfully, but these errors were encountered: