Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check typos via CI #311

Closed
orhun opened this issue Oct 10, 2023 · 2 comments · Fixed by #317
Closed

Check typos via CI #311

orhun opened this issue Oct 10, 2023 · 2 comments · Fixed by #317
Assignees
@woshilapin
Labels
good first issue Good for newcomers

Comments

@orhun
Copy link
Owner

orhun commented Oct 10, 2023

Is your feature request related to a problem? Please describe.

See #310

Describe the solution you'd like

Update the current CI workflow to check the typos in the documentation (website/markdown files).

Describe alternatives you've considered

None.

Additional context

See https://github.com/ratatui-org/ratatui/blob/main/.github/workflows/ci.yml#L54
@orhun orhun added the good first issue Good for newcomers label Oct 10, 2023
@orhun orhun self-assigned this Oct 10, 2023
@woshilapin
Copy link
Contributor

Hey there, I'd like to work on that one (will be working on #310 too as well at the same time) if that's ok.

@woshilapin woshilapin mentioned this issue Oct 15, 2023
Closed
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 15, 2023
@woshilapin
ci(typos): add 'typos' check
808e86a 
resolves orhun#311
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 15, 2023
@woshilapin
ci(typos): add 'typos' check
8985a18 
resolves orhun#311
@woshilapin woshilapin mentioned this issue Oct 15, 2023
Merged
13 tasks
@orhun orhun assigned woshilapin and unassigned orhun Oct 15, 2023
@orhun
Copy link
Owner Author

orhun commented Oct 15, 2023

Sure thing, thanks a lot for picking those up! @woshilapin

woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 16, 2023
@woshilapin
ci(typos): add 'typos' check
0973a27 
resolves orhun#311
orhun pushed a commit that referenced this issue Oct 19, 2023
@woshilapin @mergify
feat(ci): add 'typos' check (#317)
88c34ab 
* docs(docker): fix typos

* docs(readme): fix typos

* docs(template): fix typos

* ci(typos): add 'typos' check

resolves #311

* ci(typos): 'typos' moved to its own job

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woshilapin woshilapin

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ci): add 'typos' check woshilapin/git-cliff
2 participants
@woshilapin @orhun