[V5] Lucid Update with custom Primary Key stopped working

[wapacro]

Hello there

I recently updated the dependencies, after which all update actions with Lucid ORM Models that use a self assigned PK in combination with a non-conventional column name suddenly started to fail and at this point I'm not sure if it's a bug or I'm just missing something.

The following code works fine with recent core & @adonisjs/lucid <= 15.0.1 on Node v16.11.1:

app/Models/Test.ts

import { DateTime } from 'luxon'
import { BaseModel, column } from '@ioc:Adonis/Lucid/Orm'

export default class Test extends BaseModel {
  public static selfAssignPrimaryKey = true

  @column({ isPrimary: true, columnName: 'test_id' })
  public id: string

  @column()
  public comment: string | null

  @column.dateTime({ autoCreate: true })
  public createdAt: DateTime

  @column.dateTime({ autoCreate: true, autoUpdate: true })
  public updatedAt: DateTime
}

database/migrations/XXXXX_tests.ts

import BaseSchema from '@ioc:Adonis/Lucid/Schema'

export default class Tests extends BaseSchema {
  protected tableName = 'tests'

  public async up () {
    this.schema.createTable(this.tableName, (table) => {
      table.uuid('test_id').primary()
      table.string('comment')
      table.timestamp('created_at', { useTz: true })
      table.timestamp('updated_at', { useTz: true })
    })
  }

  public async down () {
    this.schema.dropTable(this.tableName)
  }
}

commands/Test.ts

import { BaseCommand } from '@adonisjs/core/build/standalone'

export default class Test extends BaseCommand {

  public static commandName = 'test'
  public static description = ''

  public static settings = {
    loadApp: true,
    stayAlive: false,
  }

  public async run () {
    const { default: Test } = await import('App/Models/Test')

    const testRow = await Test.findOrFail('dfebfab7-5932-47a3-8ca2-7f7d9717fa13')
    testRow.merge({ comment: 'Test' })
    await testRow.save()
  }
}

Assuming there's an existing row in the migrated tests table with ID "dfebfab7-5932-47a3-8ca2-7f7d9717fa13" triggering node ace test successfully updates the comment to "Test". But upgrading @adonisjs/lucid to any version >= 15.0.2 and running the same code will result in the following exception, both on MariaDB/MySQL as well as SQLite:

$ node ace test
Exception: ".where" expects value to be defined, but undefined is passed

at /mnt/d/lucid-test-fresh/commands/Test.ts(Test.run):35
31      const { default: Test } = await import('App/Models/Test')
32
33      const testRow = await Test.findOrFail('dfebfab7-5932-47a3-8ca2-7f7d9717fa13')
34      testRow.merge({ comment: 'Test' })
35      await testRow.save()
36    }
37  }
38

1 ModelQueryBuilder.validateWhereSingleArgument
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/lucid/build/src/Database/QueryBuilder/Chainable.js:150

2 ModelQueryBuilder.where
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/lucid/build/src/Database/QueryBuilder/Chainable.js:327

3 Proxy.$getQueryFor
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1549

4 Adapter.update
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/lucid/build/src/Orm/Adapter/index.js:73

5 Proxy.save
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1385

6 Test.exec
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/ace/build/src/BaseCommand/index.js:142

7 Kernel.handle
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/ace/build/src/Kernel/index.js:496

8 App.handle
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/core/build/src/Ignitor/Ace/App/index.js:286

9 Ace.handle
  /mnt/d/lucid-test-fresh/node_modules/@adonisjs/core/build/src/Ignitor/Ace/index.js:33

Any feedback is appreciated!